subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Julian Foad <>
Subject Re: [PATCH] add SMTP SSL capability to mailer
Date Thu, 05 Jan 2017 10:35:28 GMT
On 22/12/16, João M. S. Silva wrote:
> [I'm not subscribed to the list, please CC me.]
> I've discussed this patch with Daniel Shahaf in the users mailing list.
> This patch makes it possible to use e.g. Gmail's SMTP to send
> post-commit messages (using SSL).
Looks good to me, in general; I haven't tested it.

Just a minor issue: when processing other "option = yes" kind of config options, the script
doesn't convert to lower case before testing its value, so I suggest to remove ".lower()",
for consistency.

- Julian

View raw message