Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm
Precedence: bulk
Message-ID: <57246207.58811c0a.83f4b.477a@mx.google.com>
MIME-Version: 1.0
To: Daniel Shahaf <d.s@daniel.shahaf.name>,
	"dev@subversion.apache.org" <dev@subversion.apache.org>
From: Bert Huijben <bert@qqmail.nl>
Subject: RE: [PATCH/RFC] use-sasl=true in --without-sasl builds: make that
 a fatalerror?
Date: Sat, 30 Apr 2016 09:43:02 +0200
Importance: normal
In-Reply-To: <20160430005350.GA23087@tarsus.local2>
References: <20160430005350.GA23087@tarsus.local2>
Content-Type: multipart/alternative;
	boundary="_11791DCF-C504-46A5-AA0D-A8D42CF3C43D_"

--_11791DCF-C504-46A5-AA0D-A8D42CF3C43D_
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"

Isn=E2=80=99t this a documented default value?

If it is, changing the behavior will likely break many users that don=E2=80=
=99t use sasl.

Bert

Sent from my Windows 10 phone

From: Daniel Shahaf
Sent: zaterdag 30 april 2016 02:53
To: dev@subversion.apache.org
Subject: [PATCH/RFC] use-sasl=3Dtrue in --without-sasl builds: make that a =
fatalerror?

Currently, if use-sasl=3Dtrue is set in svnserve.conf but svnserve was
compiled without SASL support, SASL is silently not used.  That's
actually documented:

  svnserve.conf:
    [sasl]
    ### This option specifies whether you want to use the Cyrus SASL
    ### library for authentication. Default is false.
    ### This section will be ignored if svnserve is not built with Cyrus
    ### SASL support; to check, run 'svnserve --version' and look for a lin=
e
    ### reading 'Cyrus SASL authentication is available.'
    # use-sasl =3D true

But documentation notwithstanding, it seems like a misfeature.  Should
we change this, so --without-sasl builds will error out if use-sasl=3Dtrue
is set?  The patch would be simple enough (attached).

Cheers,

Daniel

P.S. The 'password-db' setting is in the same boat: it's ignored
when SASL is enabled, and documented this way.  However, I'm not
convinced a change to that setting's handling is needed.


--_11791DCF-C504-46A5-AA0D-A8D42CF3C43D_
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html; charset="utf-8"

<html xmlns:o=3D"urn:schemas-microsoft-com:office:office" xmlns:w=3D"urn:sc=
hemas-microsoft-com:office:word" xmlns:m=3D"http://schemas.microsoft.com/of=
fice/2004/12/omml" xmlns=3D"http://www.w3.org/TR/REC-html40"><head><meta ht=
tp-equiv=3DContent-Type content=3D"text/html; charset=3Dutf-8"><meta name=
=3DGenerator content=3D"Microsoft Word 15 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
	{font-family:"Cambria Math";
	panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
	{font-family:Calibri;
	panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
	{margin:0cm;
	margin-bottom:.0001pt;
	font-size:11.0pt;
	font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
	{mso-style-priority:99;
	color:blue;
	text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
	{mso-style-priority:99;
	color:#954F72;
	text-decoration:underline;}
.MsoChpDefault
	{mso-style-type:export-only;}
@page WordSection1
	{size:612.0pt 792.0pt;
	margin:70.85pt 70.85pt 70.85pt 70.85pt;}
div.WordSection1
	{page:WordSection1;}
--></style></head><body lang=3DNL link=3Dblue vlink=3D"#954F72"><div class=
=3DWordSection1><p class=3DMsoNormal><span lang=3DEN-US>Isn=E2=80=99t this =
a documented default value?</span><o:p></o:p></p><p class=3DMsoNormal><o:p>=
&nbsp;</o:p></p><p class=3DMsoNormal><span lang=3DEN-US>If it is, changing =
the behavior will likely break many users that don=E2=80=99t use sasl.<o:p>=
</o:p></span></p><p class=3DMsoNormal><span lang=3DEN-US><o:p>&nbsp;</o:p><=
/span></p><p class=3DMsoNormal><span lang=3DEN-US>Bert</span><o:p></o:p></p=
><p class=3DMsoNormal><o:p>&nbsp;</o:p></p><p class=3DMsoNormal>Sent from m=
y Windows 10 phone</p><p class=3DMsoNormal><span style=3D'font-size:12.0pt;=
font-family:"Times New Roman",serif'><o:p>&nbsp;</o:p></span></p><div style=
=3D'mso-element:para-border-div;border:none;border-top:solid #E1E1E1 1.0pt;=
padding:3.0pt 0cm 0cm 0cm'><p class=3DMsoNormal style=3D'border:none;paddin=
g:0cm'><b>From: </b><a href=3D"mailto:d.s@daniel.shahaf.name">Daniel Shahaf=
</a><br><b>Sent: </b>zaterdag 30 april 2016 02:53<br><b>To: </b><a href=3D"=
mailto:dev@subversion.apache.org">dev@subversion.apache.org</a><br><b>Subje=
ct: </b>[PATCH/RFC] use-sasl=3Dtrue in --without-sasl builds: make that a f=
atalerror?</p></div><p class=3DMsoNormal><span style=3D'font-size:12.0pt;fo=
nt-family:"Times New Roman",serif'><o:p>&nbsp;</o:p></span></p><p class=3DM=
soNormal>Currently, if use-sasl=3Dtrue is set in svnserve.conf but svnserve=
 was</p><p class=3DMsoNormal>compiled without SASL support, SASL is silentl=
y not used.=C2=A0 That's</p><p class=3DMsoNormal>actually documented:</p><p=
 class=3DMsoNormal><o:p>&nbsp;</o:p></p><p class=3DMsoNormal>=C2=A0 svnserv=
e.conf:</p><p class=3DMsoNormal>=C2=A0=C2=A0=C2=A0 [sasl]</p><p class=3DMso=
Normal>=C2=A0=C2=A0=C2=A0 ### This option specifies whether you want to use=
 the Cyrus SASL</p><p class=3DMsoNormal>=C2=A0=C2=A0=C2=A0 ### library for =
authentication. Default is false.</p><p class=3DMsoNormal>=C2=A0=C2=A0=C2=
=A0 ### This section will be ignored if svnserve is not built with Cyrus</p=
><p class=3DMsoNormal>=C2=A0=C2=A0=C2=A0 ### SASL support; to check, run 's=
vnserve --version' and look for a line</p><p class=3DMsoNormal>=C2=A0=C2=A0=
=C2=A0 ### reading 'Cyrus SASL authentication is available.'</p><p class=3D=
MsoNormal>=C2=A0=C2=A0=C2=A0 # use-sasl =3D true</p><p class=3DMsoNormal><o=
:p>&nbsp;</o:p></p><p class=3DMsoNormal>But documentation notwithstanding, =
it seems like a misfeature.=C2=A0 Should</p><p class=3DMsoNormal>we change =
this, so --without-sasl builds will error out if use-sasl=3Dtrue</p><p clas=
s=3DMsoNormal>is set?=C2=A0 The patch would be simple enough (attached).</p=
><p class=3DMsoNormal><o:p>&nbsp;</o:p></p><p class=3DMsoNormal>Cheers,</p>=
<p class=3DMsoNormal><o:p>&nbsp;</o:p></p><p class=3DMsoNormal>Daniel</p><p=
 class=3DMsoNormal><o:p>&nbsp;</o:p></p><p class=3DMsoNormal>P.S. The 'pass=
word-db' setting is in the same boat: it's ignored</p><p class=3DMsoNormal>=
when SASL is enabled, and documented this way.=C2=A0 However, I'm not</p><p=
 class=3DMsoNormal>convinced a change to that setting's handling is needed.=
</p><p class=3DMsoNormal><o:p>&nbsp;</o:p></p><p class=3DMsoNormal><o:p>&nb=
sp;</o:p></p></div></body></html>=

--_11791DCF-C504-46A5-AA0D-A8D42CF3C43D_--