Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <20160328133749.GA84858@jim.stsp.name>
References: <20160319221835.DAED23A0051@svn01-us-west.apache.org>
 <CABw-3Yf=_p2yt=-pJ3Vq8qw3UYjpbyyZbmC=h-RJv0NNroHwHA@mail.gmail.com>
 <20160328133749.GA84858@jim.stsp.name>
From: Ivan Zhakov <ivan@visualsvn.com>
Date: Mon, 28 Mar 2016 16:49:23 +0300
Message-ID: 
 <CABw-3YeEi3SzNUv_G3S3_YgtGbFP2Jh-PVajSqyhA=Vz6Enc5w@mail.gmail.com>
Subject: Re: svn commit: r1735826 - in /subversion/trunk: ./
 subversion/libsvn_subr/prompt.c
To: Ivan Zhakov <ivan@visualsvn.com>, dev@subversion.apache.org,
 danielsh@apache.org
Content-Type: text/plain; charset=UTF-8

On 28 March 2016 at 16:37, Stefan Sperling <stsp@apache.org> wrote:
> On Mon, Mar 28, 2016 at 04:13:11PM +0300, Ivan Zhakov wrote:
>> On 20 March 2016 at 01:18,  <danielsh@apache.org> wrote:
>> >          {
>> >            if (err->apr_err == SVN_ERR_CANCELLED)
>> >              {
>> > -              svn_error_clear(err);
>> >                *may_save_plaintext = FALSE;
>> > -              return SVN_NO_ERROR;
>> > +              return err;
>> Daniel, do you know what was the original idea behind ignoring the
>> SVN_ERR_CANCELLED error? I see stsp committed the original code in
>> r870804, so there's probably some rationale behind it.
>>
>> Stefan, do you remember any details?
>
> I don't think there was a special reason to ignore the error.
>
> The question is whether we want Ctrl-C to mean "no" at the plaintext
> prompt, or whether it should abort the process.
>
> I agree with Daniel's patch. Ctrl-C should abort the process.
OK. Thanks for clarification! I just wanted to double check that we're
not missing something important.


-- 
Ivan Zhakov