Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <20150930144926.AC2CD3A0248@svn01-us-west.apache.org>
References: <20150930144926.AC2CD3A0248@svn01-us-west.apache.org>
From: Ivan Zhakov <ivan@visualsvn.com>
Date: Mon, 28 Mar 2016 18:33:57 +0300
Message-ID: 
 <CABw-3YcS+ERcsp_T8Hf=GfL2cHt_5xdFwjjrfMaD4So+HJrLJA@mail.gmail.com>
Subject: Re: svn commit: r1706049 - in /subversion/trunk/subversion:
 libsvn_diff/parse-diff.c tests/cmdline/patch_tests.py
To: dev@subversion.apache.org, Bert Huijben <bert@qqmail.nl>
Content-Type: text/plain; charset=UTF-8

On 30 September 2015 at 17:49,  <rhuijben@apache.org> wrote:
> Author: rhuijben
> Date: Wed Sep 30 14:49:25 2015
> New Revision: 1706049
>
> URL: http://svn.apache.org/viewvc?rev=1706049&view=rev
> Log:
> Make it possible to possible to apply git style mode changes and binary file
> patches at the same time.
>
[...]
>
> Modified: subversion/trunk/subversion/tests/cmdline/patch_tests.py
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/cmdline/patch_tests.py?rev=1706049&r1=1706048&r2=1706049&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/tests/cmdline/patch_tests.py (original)
> +++ subversion/trunk/subversion/tests/cmdline/patch_tests.py Wed Sep 30 14:49:25 2015
> @@ -6572,6 +6572,107 @@ def patch_empty_vs_delete(sbox):
>                                         [], True, True,
>                                         '--reverse-diff')
>
> +def patch_add_remove_executable(sbox):
> +  "add and remove executable file"
> +
> +  sbox.build()
> +  wc_dir = sbox.wc_dir
> +
> +  eicar_data = 'X5O!P%@AP[4\PZX54(P^)7CC)7}$' \
> +               'EICAR-STANDARD-ANTIVIRUS-TEST-FILE!$H+H*\0'
> +  other_data = 'X5O!P%@AP[4\PZX54(P^)7CC)7}$' \
> +               'SOME-LESS-INTERESTING-OTHER-TEXT!!!$H+H*\0'
> +
Hi Bert,

This test fails for me on Windows 10 with Windows defender enabled
with error like this:
[[[
W: svn: E720225: Can't open file
'C:\Users\ivan.OSTYSERVER\AppData\Local\Temp\svn-test-trunk-http\subversion\tests\cmdline\svn-test-work\working_copies\patch_tests-69\eicar.com':
Operation did not complete successfully because the file contains a
virus or potentially unwanted software.
]]]

The file is recognized as virus since it's special test file for
antivirus testing and blocks access to it. Do we really need using
eicar.com in this test case?

-- 
Ivan Zhakov