Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm
Precedence: bulk
From: Dmitry Pavlenko <pavlenko@tmatesoft.com>
To: Branko =?utf-8?q?=C4=8Cibej?= <brane@apache.org>
Subject: Re: [PATCH] Make constructors of JavaHL classes public
Date: Tue, 8 Mar 2016 22:40:56 +0100
User-Agent: KMail/1.13.7 (Linux/3.2.0-4-amd64; KDE/4.8.4; x86_64; ; )
Cc: dev@subversion.apache.org
References: <201603081735.19635.pavlenko@tmatesoft.com>
 <56DF4415.3040406@apache.org>
In-Reply-To: <56DF4415.3040406@apache.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <201603082240.56350.pavlenko@tmatesoft.com>
X-Spam_score: -2.9
X-Spam_score_int: -28
X-Spam_bar: --
X-Spam_report: Spam detection software,
 running on the system "www.tmatesoft.com", has
 identified this incoming email as possible spam.  The original message
 has been attached to this so you can view it (if it isn't spam) or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview:  Yes, it would be enough, thanks! > On 08.03.2016 17:35,
 Dmitry
    Pavlenko wrote: > > Hello! > > I would ask you to make some JavaHL
 contructors
    public, so it would be > > possible to implement JavaHL more easily. Once
    you were so kind to do > > that > > > >
 https://mail-archives.apache.org/mod_mbox/subversion-dev/201309.mbox/%3C2
    > > 01309041617.25159.pavlenko@tmatesoft.com%3E > > > > and I'm asking you
    to do that once again. > > Would it work for you if we make the
 constructors
    package-scope instead > of public? You'd still be able to create the
 objects
    in your > implementation; but the user-facing API really shouldn't allow
   object > creation in these cases. > > -- Brane [...]  
 Content analysis details:   (-2.9 points, 5.0 required)
  pts rule name              description
 ---- ----------------------
 --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
                             [score: 0.0000]

Yes, it would be enough, thanks!

> On 08.03.2016 17:35, Dmitry Pavlenko wrote:
> > Hello!
> > I would ask you to make some JavaHL contructors public, so it would be
> > possible to implement JavaHL more easily. Once you were so kind to do
> > that
> > 
> > https://mail-archives.apache.org/mod_mbox/subversion-dev/201309.mbox/%3C2
> > 01309041617.25159.pavlenko@tmatesoft.com%3E
> > 
> > and I'm asking you to do that once again.
> 
> Would it work for you if we make the constructors package-scope instead
> of public? You'd still be able to create the objects in your
> implementation; but the user-facing API really shouldn't allow object
> creation in these cases.
> 
> -- Brane