Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm
Precedence: bulk
From: Philip Martin <philip.martin@wandisco.com>
To: Daniel Shahaf <d.s@daniel.shahaf.name>
Cc: dev@subversion.apache.org,  commits@subversion.apache.org
Subject: Re: svn commit: r1727621 - in /subversion/trunk/subversion: svn/svn.c
 svnadmin/svnadmin.c svnbench/svnbench.c svnfsfs/svnfsfs.c svnlook/svnlook.c
 svnrdump/svnrdump.c svnsync/svnsync.c
References: <20160129185522.A2F813A0249@svn01-us-west.apache.org>
	<20160130074708.GA30257@tarsus.local2>
Date: Mon, 01 Feb 2016 10:41:04 +0000
In-Reply-To: <20160130074708.GA30257@tarsus.local2> (Daniel Shahaf's message
	of "Sat, 30 Jan 2016 07:47:08 +0000")
Message-ID: <87h9hsaf27.fsf@wandisco.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain

Daniel Shahaf <d.s@daniel.shahaf.name> writes:

> philip@apache.org wrote on Fri, Jan 29, 2016 at 18:55:22 -0000:
>> +#ifndef WIN32
>> +  /* If cancelled by SIGINT then attempt to exit via SIGINT.  This
>> +     allows the shell to use WIFSIGNALED and WTERMSIG to detect the
>> +     SIGINT.  See http://www.cons.org/cracauer/sigint.html  */
>> +  if (cancelled && apr_signal(SIGINT, SIG_DFL) == APR_SUCCESS)
>> +    /* No APR support for getpid() so cannot use apr_proc_kill(). */
>> +    kill(getpid(), SIGINT);
>> +#endif
>
> Should this be done for other signals we catch?  (Those signals are
> SIGTERM, SIGHUP, and SIGBREAK.)  Shells handle those values of
> WTERMSIG() too:
>
> % perl -e 'kill "TERM", $$'
> zsh: terminated  perl -e 'kill "TERM", $$'

That change is broken for two reasons:

 - the same handler is used for all those signals but we always exit via
   SIGINT

 - except apr_signal does not return APR_SUCCESS so we never exit via
   SIGINT.

-- 
Philip Martin
WANdisco