Return-Path: X-Original-To: apmail-subversion-dev-archive@minotaur.apache.org Delivered-To: apmail-subversion-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EBE981834D for ; Sun, 21 Feb 2016 13:28:38 +0000 (UTC) Received: (qmail 88085 invoked by uid 500); 21 Feb 2016 13:28:38 -0000 Delivered-To: apmail-subversion-dev-archive@subversion.apache.org Received: (qmail 88025 invoked by uid 500); 21 Feb 2016 13:28:38 -0000 Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@subversion.apache.org Received: (qmail 88011 invoked by uid 99); 21 Feb 2016 13:28:38 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 21 Feb 2016 13:28:38 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 29B49C0405; Sun, 21 Feb 2016 13:28:38 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.699 X-Spam-Level: X-Spam-Status: No, score=-0.699 tagged_above=-999 required=6.31 tests=[RCVD_IN_DNSWL_LOW=-0.7, UNPARSEABLE_RELAY=0.001] autolearn=disabled Received: from mx2-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id Ongi16tZ81Bp; Sun, 21 Feb 2016 13:28:36 +0000 (UTC) Received: from einhorn.in-berlin.de (einhorn.in-berlin.de [192.109.42.8]) by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with ESMTPS id 01EC45FB0A; Sun, 21 Feb 2016 13:28:32 +0000 (UTC) X-Envelope-From: stsp@elego.de Received: from ted.stsp.name (ted.stsp.name [217.197.84.34]) by einhorn.in-berlin.de (8.14.4/8.14.4/Debian-4) with ESMTP id u1LDSOno007406 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 21 Feb 2016 14:28:24 +0100 Received: from localhost (ted.stsp.name [local]) by ted.stsp.name (OpenSMTPD) with ESMTPA id ec80b335; Sun, 21 Feb 2016 14:28:24 +0100 (CET) Date: Sun, 21 Feb 2016 14:28:24 +0100 From: Stefan Sperling To: Branko =?utf-8?B?xIxpYmVq?= Cc: Subversion Development Subject: Re: svn commit: r1731300 - in /subversion/trunk/subversion: include/private/svn_utf_private.h libsvn_repos/dump.c libsvn_subr/utf8proc.c svn/cl-log.h svn/log-cmd.c svn/svn.c tests/cmdline/log_tests.py tests/libsvn_subr/utf-test.c Message-ID: <20160221132824.GH268@ted.stsp.name> Mail-Followup-To: Branko =?utf-8?B?xIxpYmVq?= , Subversion Development References: <20160219221112.017573A0185@svn01-us-west.apache.org> <3d4f01d16bcf$1cb68120$56238360$@qqmail.nl> <56C88CE8.1000902@apache.org> <56C9BA25.5050706@apache.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <56C9BA25.5050706@apache.org> User-Agent: Mutt/1.5.23 (2014-03-12) On Sun, Feb 21, 2016 at 02:22:45PM +0100, Branko Čibej wrote: > Personally I'd much prefer the svn_utf__casefold() you propose (i.e., > normalize plus casefold) as a separate API. Internally, it can be > implemented with that extra flag, but even for a private API, I think > it's better to make each function do one thing. +1