Return-Path: X-Original-To: apmail-subversion-dev-archive@minotaur.apache.org Delivered-To: apmail-subversion-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BFD5D184C3 for ; Thu, 12 Nov 2015 16:55:07 +0000 (UTC) Received: (qmail 38628 invoked by uid 500); 12 Nov 2015 16:55:07 -0000 Delivered-To: apmail-subversion-dev-archive@subversion.apache.org Received: (qmail 38576 invoked by uid 500); 12 Nov 2015 16:55:07 -0000 Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@subversion.apache.org Received: (qmail 38566 invoked by uid 99); 12 Nov 2015 16:55:07 -0000 Received: from Unknown (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Nov 2015 16:55:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id C96C01A074B for ; Thu, 12 Nov 2015 16:55:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.879 X-Spam-Level: ** X-Spam-Status: No, score=2.879 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id lnpqQrrEAHAV for ; Thu, 12 Nov 2015 16:55:06 +0000 (UTC) Received: from mail-vk0-f46.google.com (mail-vk0-f46.google.com [209.85.213.46]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with ESMTPS id B141F207E3 for ; Thu, 12 Nov 2015 16:55:05 +0000 (UTC) Received: by vkas68 with SMTP id s68so14472243vka.2 for ; Thu, 12 Nov 2015 08:54:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=46rHqaYMH+8ZkyT2tkwDFVihdhYvksCpHnFKUUuJxbo=; b=m3KGuko8IOR4zt7SRytbwoAIJ4mEL4HIu3IV9csANOG8JVqDQtXXphA3cX6MkBAIJ1 FHXiLQ8wIJLiBIFBazAax1M8y2OQwqU7oLRhAYHu5sGtF1NlN+X2blDgqiyu8FYWeEgT Rd1dxrhET9mhTl6tubCIjqBsFqfslji7vTJFSgy1qvIRW1wHWdCfBtRLetPmF9EG+gKv nlaCbfsbejs7UwQ46XYJzNZFQxJdj6/zr3J6Pnmte3XIk0sldV+5odBpukbg6kvsYwtt I9zVt86bzcKXlsZWZjRZxL7DF01Bfb/FHemxiOIyyuGJvN4Km4pWYP+SRMtEyvIOj9q7 2mow== MIME-Version: 1.0 X-Received: by 10.31.3.1 with SMTP id 1mr4552614vkd.7.1447347298651; Thu, 12 Nov 2015 08:54:58 -0800 (PST) Received: by 10.31.148.16 with HTTP; Thu, 12 Nov 2015 08:54:58 -0800 (PST) In-Reply-To: <20151112085958.F133E3A1597@svn01-us-west.apache.org> References: <20151112085958.F133E3A1597@svn01-us-west.apache.org> Date: Thu, 12 Nov 2015 10:54:58 -0600 Message-ID: Subject: Re: svn commit: r1713980 [4/6] - in /subversion/branches/move-tracking-2/subversion: include/private/ libsvn_client/ libsvn_delta/ libsvn_ra/ libsvn_ra_local/ libsvn_repos/ libsvn_wc/ svnmover/ From: Greg Stein To: dev@subversion.apache.org Content-Type: multipart/alternative; boundary=001a11427b609a568e05245acd85 --001a11427b609a568e05245acd85 Content-Type: text/plain; charset=UTF-8 On Thu, Nov 12, 2015 at 2:59 AM, wrote: >... > +++ subversion/branches/move-tracking-2/subversion/libsvn_ra/ra_loader.c > Thu Nov 12 08:59:57 2015 > @@ -679,8 +679,8 @@ write_rev_prop(svn_ra_session_t *ra_sess > * branch-tracking metadata from the repository into it. > */ > static svn_error_t * > -svn_branch_revision_fetch_info(svn_branch_txn_t **txn_p, > - svn_branch_repos_t *repos, > +svn_branch_revision_fetch_info(svn_branch__txn_t **txn_p, > Seems you've missed a class of renames. Shouldn't this function name be renamed, too? >... Cheers, -g --001a11427b609a568e05245acd85 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On T= hu, Nov 12, 2015 at 2:59 AM, <julianfoad@apache.org> wr= ote:
>...
+++ subversion/branches/move-tracking-2/subversion/libsvn_ra/ra_loader.= c Thu Nov 12 08:59:57 2015
@@ -679,8 +679,8 @@ write_rev_prop(svn_ra_session_t *ra_sess
=C2=A0 * branch-tracking metadata from the repository into it.
=C2=A0 */
=C2=A0static svn_error_t *
-svn_branch_revision_fetch_info(svn_branch_txn_t **txn_p,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0svn_branch_repos_t *repos,
+svn_branch_revision_fetch_info(svn_branch__txn_t **txn_p,
=

Seems you've missed a class of renames. Shouldn'= ;t this function name be renamed, too?

>...

Cheers,
-g

=
--001a11427b609a568e05245acd85--