Return-Path: X-Original-To: apmail-subversion-dev-archive@minotaur.apache.org Delivered-To: apmail-subversion-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 72BE418853 for ; Thu, 12 Nov 2015 23:32:46 +0000 (UTC) Received: (qmail 15128 invoked by uid 500); 12 Nov 2015 23:32:46 -0000 Delivered-To: apmail-subversion-dev-archive@subversion.apache.org Received: (qmail 15076 invoked by uid 500); 12 Nov 2015 23:32:46 -0000 Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@subversion.apache.org Received: (qmail 15066 invoked by uid 99); 12 Nov 2015 23:32:46 -0000 Received: from Unknown (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Nov 2015 23:32:46 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 8F1631801DA for ; Thu, 12 Nov 2015 23:32:45 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.879 X-Spam-Level: ** X-Spam-Status: No, score=2.879 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id crvdcMAUgrp4 for ; Thu, 12 Nov 2015 23:32:44 +0000 (UTC) Received: from mail-yk0-f173.google.com (mail-yk0-f173.google.com [209.85.160.173]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with ESMTPS id C1A7B20CB8 for ; Thu, 12 Nov 2015 23:32:43 +0000 (UTC) Received: by ykdv3 with SMTP id v3so120418951ykd.0 for ; Thu, 12 Nov 2015 15:32:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=GAqm5xB4+5ZpBS+VaSYR3JlzhsbciSFM+g/OlGvmDSo=; b=d+JLvUTrMubDp2oem1TvNowMTe6KoUFIIaVFY+56D0TvlkqGS1rmlXFExDua8dmfxE Zm6EbqvmYi1SoFOh/+ftj5SSFYygWxafVkg+eU0ORO33KWzwWhdky/CRSZakv/8wp6s9 hXNMAsrQYz7rG+XMUED/gMZVvooQRFcVECvwufhMIfQFL04GXZlE5nxwHHTITOgSGhvd TKEk0tfe/b+yyA/W3lWWeVgnpmBrb4/rVMtl5K4VaTBuniLFjoe4tbdKY6FQcr0oSnEi 2/MafzKFKxOgX4OxZlwGUtgVNNgtDp1Vp2k3ny20DxuAQeTMysuABoOqAircS+WD3bZY Q8qQ== MIME-Version: 1.0 X-Received: by 10.13.196.193 with SMTP id g184mr17658708ywd.293.1447371157694; Thu, 12 Nov 2015 15:32:37 -0800 (PST) Received: by 10.31.148.16 with HTTP; Thu, 12 Nov 2015 15:32:37 -0800 (PST) In-Reply-To: References: <20151112085958.F133E3A1597@svn01-us-west.apache.org> Date: Thu, 12 Nov 2015 17:32:37 -0600 Message-ID: Subject: Re: svn commit: r1713980 [4/6] - in /subversion/branches/move-tracking-2/subversion: include/private/ libsvn_client/ libsvn_delta/ libsvn_ra/ libsvn_ra_local/ libsvn_repos/ libsvn_wc/ svnmover/ From: Greg Stein To: Julian Foad Cc: dev Content-Type: multipart/alternative; boundary=001a114d7ec8b66ff70524605baa --001a114d7ec8b66ff70524605baa Content-Type: text/plain; charset=UTF-8 Oh! I missed the static. ... then I guess dropping the prefix altogether would be the correct "fix". ?? On Thu, Nov 12, 2015 at 4:38 PM, Julian Foad wrote: > Well spotted, thanks. I didn't find this as it's a local name (static > func), although I did catch a couple of other such cases. Will fix. > > - Julian > > On 12 November 2015 at 16:54, Greg Stein wrote: > > On Thu, Nov 12, 2015 at 2:59 AM, wrote: > >>... > >> > >> +++ subversion/branches/move-tracking-2/subversion/libsvn_ra/ra_loader.c > >> Thu Nov 12 08:59:57 2015 > >> @@ -679,8 +679,8 @@ write_rev_prop(svn_ra_session_t *ra_sess > >> * branch-tracking metadata from the repository into it. > >> */ > >> static svn_error_t * > >> -svn_branch_revision_fetch_info(svn_branch_txn_t **txn_p, > >> - svn_branch_repos_t *repos, > >> +svn_branch_revision_fetch_info(svn_branch__txn_t **txn_p, > > > > > > Seems you've missed a class of renames. Shouldn't this function name be > > renamed, too? > > > >>... > > > > Cheers, > > -g > > > --001a114d7ec8b66ff70524605baa Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Oh! I missed the static. ... then I guess dropping the pre= fix altogether would be the correct "fix". ??

On Thu, Nov 12, 2015 at 4:38 PM= , Julian Foad <julianfoad@gmail.com> wrote:
Well spotted, thanks. I didn't find this as it'= ;s a local name (static
func), although I did catch a couple of other such cases. Will fix.

- Julian

On 12 November 2015 at 16:54, Greg Stein <gstein@gmail.com> wrote:
> On Thu, Nov 12, 2015 at 2:59 AM, <julianfoad@apache.org> wrote:
>>...
>>
>> +++ subversion/branches/move-tracking-2/subversion/libsvn_ra/ra_lo= ader.c
>> Thu Nov 12 08:59:57 2015
>> @@ -679,8 +679,8 @@ write_rev_prop(svn_ra_session_t *ra_sess
>>=C2=A0 =C2=A0* branch-tracking metadata from the repository into it= .
>>=C2=A0 =C2=A0*/
>>=C2=A0 static svn_error_t *
>> -svn_branch_revision_fetch_info(svn_branch_txn_t **txn_p,
>> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0svn_branch_repos_t *repos,<= br> >> +svn_branch_revision_fetch_info(svn_branch__txn_t **txn_p,
>
>
> Seems you've missed a class of renames. Shouldn't this functio= n name be
> renamed, too?
>
>>...
>
> Cheers,
> -g
>

--001a114d7ec8b66ff70524605baa--