Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm
Precedence: bulk
From: Philip Martin <philip.martin@wandisco.com>
To: James McCoy <jamessan@debian.org>
Cc: Subversion devel mailing list <dev@subversion.apache.org>
Subject: Re: [PATCH] Convert Ruby tests from test-unit to minitest
References: <1446694782-26637-1-git-send-email-jamessan@debian.org>
	<87bnb8wusk.fsf@wandisco.com>
	<CAFeRdpdkUmcjakA8jCJdi6HS8irTjZtboHLu5Vj6_BaiqhGh+g@mail.gmail.com>
	<20151108030937.GC8248@freya.jamessan.com>
	<20151109051551.GC13855@freya.jamessan.com>
	<20151117020829.GE13304@freya.jamessan.com>
Date: Tue, 17 Nov 2015 13:03:49 +0000
In-Reply-To: <20151117020829.GE13304@freya.jamessan.com> (James McCoy's
	message of "Mon, 16 Nov 2015 21:08:30 -0500")
Message-ID: <87h9kkydze.fsf@wandisco.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain

James McCoy <jamessan@debian.org> writes:

> On Mon, Nov 09, 2015 at 12:15:51AM -0500, James McCoy wrote:
>> On Sat, Nov 07, 2015 at 10:09:37PM -0500, James McCoy wrote:
>> > The attached patch, however, at least gets the test suite working with
>> > the test-unit gem, which is a pre-requisite for testing against Ruby
>> > 2.2.
>> 
>> Updated to fix a typo in Makefile.in.
>
> Ping?

Doesn't work on my Debian/stable box if I have the ruby-minitest package
installed. I think check_rb() is failing with:

/usr/lib/ruby/2.1.0/test/unit.rb:676:in `<class:Runner>': undefined method `_run_suite' for class `Test::Unit::Runner' (NameError)

If I don't have ruby-minitest installed then the tests work.  It appears
that ruby comes with minitest 4.7.5 and that works, but ruby-mintest
installs 5.4.2 and that fails.

Full error:

$ make check-swig-rb
if [ "LD_LIBRARY_PATH" = "DYLD_LIBRARY_PATH" ]; then for d in /home/pm/sw/subversion/obj/subversion/bindings/swig/ruby/libsvn_swig_ruby /home/pm/sw/subversion/obj/subversion/bindings/swig/ruby/../../../libsvn_*; do if [ -n "$DYLD_LIBRARY_PATH" ]; then LD_LIBRARY_PATH="$LD_LIBRARY_PATH:$d/.libs"; else LD_LIBRARY_PATH="$d/.libs"; fi; done; export LD_LIBRARY_PATH; fi; \
cd /home/pm/sw/subversion/obj/subversion/bindings/swig/ruby; \
  check_rb() { \
    /usr/bin/ruby -I /home/pm/sw/subversion/obj/../src/subversion/bindings/swig/ruby /home/pm/sw/subversion/obj/../src/subversion/bindings/swig/ruby/test/run-test.rb "$@"; \
  }; \
  if check_rb --help 2>&1 | grep -q -- --collector; then \
    check_rb --collector=dir --verbose=normal; \
  elif [ "2" -eq 1 -a "1" -lt 9 ] ; then \
    check_rb --verbose=normal; \
  else \
    check_rb; \
          fi
Warning: you should require 'minitest/autorun' instead.
Warning: or add 'gem "minitest"' before 'require "minitest/autorun"'
From:
  /usr/lib/ruby/2.1.0/test/unit.rb:1:in `<top (required)>'
  /home/pm/sw/subversion/obj/../src/subversion/bindings/swig/ruby/test/run-test.rb:22:in `<main>'
MiniTest::Unit::TestCase is now Minitest::Test. From /usr/lib/ruby/2.1.0/test/unit/testcase.rb:8:in `<module:Unit>'
/usr/lib/ruby/2.1.0/test/unit.rb:676:in `<class:Runner>': undefined method `_run_suite' for class `Test::Unit::Runner' (NameError)
	from /usr/lib/ruby/2.1.0/test/unit.rb:261:in `<module:Unit>'
	from /usr/lib/ruby/2.1.0/test/unit.rb:15:in `<module:Test>'
	from /usr/lib/ruby/2.1.0/test/unit.rb:7:in `<top (required)>'
	from /usr/lib/ruby/2.1.0/rubygems/core_ext/kernel_require.rb:55:in `require'
	from /usr/lib/ruby/2.1.0/rubygems/core_ext/kernel_require.rb:55:in `require'
	from /home/pm/sw/subversion/obj/../src/subversion/bindings/swig/ruby/test/run-test.rb:22:in `<main>'
Makefile:922: recipe for target 'check-swig-rb' failed
make: *** [check-swig-rb] Error 1

-- 
Philip Martin
WANdisco