Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm
Precedence: bulk
From: "Bert Huijben" <bert@qqmail.nl>
To: "'Daniel Shahaf'" <danielsh@apache.org>,
	"'Philip Martin'" <philip.martin@wandisco.com>
Cc: =?iso-8859-2?Q?'Branko_=C8ibej'?= <brane@apache.org>,
	<dev@subversion.apache.org>
References: <20151125213120.9C7FE3A02EE@svn01-us-west.apache.org>
 <010901d127d0$81dadc60$85909520$@qqmail.nl> <5656395A.60807@apache.org>
 <011601d127d7$8def30d0$a9cd9270$@qqmail.nl> <87610olvpc.fsf@wandisco.com>
 <871tbclj6k.fsf@wandisco.com> <20151128173200.GA64152@minotaur.apache.org>
In-Reply-To: <20151128173200.GA64152@minotaur.apache.org>
Subject: RE: svn commit: r1716548 -
 /subversion/trunk/subversion/tests/libsvn_fs/fs-test.c
Date: Sat, 28 Nov 2015 21:58:00 +0100
Message-ID: <03ec01d12a1f$791d6f60$6b584e20$@qqmail.nl>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-2"
Content-Transfer-Encoding: quoted-printable
Thread-Index: 
 AQKdgnenhKXBgV+Z7gXJrJQ9xKlC7QGXwi9DA05vYpcBq+ngrALRo9OcAYmBwWQCRDbtrpyvrJyA
Content-Language: nl


> -----Original Message-----
> From: Daniel Shahaf [mailto:danielsh@apache.org]
> Sent: zaterdag 28 november 2015 18:32
> To: Philip Martin <philip.martin@wandisco.com>
> Cc: Bert Huijben <bert@qqmail.nl>; 'Branko =C8ibej' =
<brane@apache.org>;
> dev@subversion.apache.org
> Subject: Re: svn commit: r1716548 -
> /subversion/trunk/subversion/tests/libsvn_fs/fs-test.c
>=20
> On Thu, Nov 26, 2015 at 06:17:07PM +0000, Philip Martin wrote:
> > Philip Martin <philip.martin@wandisco.com> writes:
> >
> > > I suppose one way to fix this would be to ensure that every BDB
revision
> > > generates a new node-revision-id.
> >
> > To do this we make '/' mutable either when creating the txn, or when
> > commiting the txn.  Patches to do both below.  Not sure which one is
> > best.
>=20
> Making '/' mutable at transaction creation would violate an explicit =
API
> promise:

If you interpret it this way FSFS always broke the promise
>=20
>     /** Set @a *revision to the revision in which @a path under @a =
root
was
>      * created.  Use @a pool for any temporary allocations.  @a =
*revision
will
>      * be set to #SVN_INVALID_REVNUM for uncommitted nodes (i.e.
> modified nodes
>      * under a transaction root).  Note that the root of an unmodified
> transaction
>      * is not itself considered to be modified; in that case, return =
the
revision
>      * upon which the transaction was based.
>      */
>     svn_error_t *
>     svn_fs_node_created_rev(svn_revnum_t *revision,

And strictly the root directory is not *under* the root.

I'm not sure what the right way to fix this problem is... but calling =
fsfs
completely broken is not the solution for fixing this inconsistency.


And if you open a transaction against r3... then what is the revision =
the
transaction is based on?

r3?
FSFS and FSX always think so


r1?
If both r2 and r3 didn't contain modifications, BDB thinks so (see the
recently added RA C test)


(The commit can even be applied on top of r4, if this doesn't conflict)

	Bert