subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Julian Foad <julianf...@gmail.com>
Subject Re: Merge 'svnmover' demo tool to trunk
Date Wed, 11 Nov 2015 09:39:00 GMT
Stefan Fuhrmann wrote:
> Julian Foad wrote:
>> The work on the 'move-tracking-2' branch currently consists of some
>> library functions (mostly named 'svn_branch_*') which are used only by
>> the demo tool named 'svnmover'. These do not interfere with normal
>> Subversion operation at all. I propose to merge this to trunk to lower
>> the barrier to participation in this work.
>
> If we want to merge the branch, now is a good time to do so
> because we are still in the early stages of 1.10 development.
>
> As Bert already mentioned, we should not introduce new public
> API for functionality that we don't plan to maintain post-1.10.
> The header files are already correctly placed under "private"
> but getting the renames done before merging would reduce the
> code churn on trunk.

I'll do that.

>> I first need to review a few places where I touched existing code to
>> insert 'shims'; only a small part of this would remain, I think, as
>> bidirectional shims are not currently available.
>
> Another good reason for merging: See what parts of the existing
> code it needs to interact with.  Yes, diff would tell us the
> same but only if one is very careful to pick a good path@rev
> pair.  On trunk, people may feel more inclined to review and
> adjust those points of interaction.
>
>> Any objections?
>
> Once the cleanup is done, +1 on merge.

Thanks for your comments, Bert and Stefan.

I'll plan to merge on Monday.

- Julian

Mime
View raw message