subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James McCoy <james...@debian.org>
Subject Re: [PATCH] Fix modification of nil value in Ruby test suite
Date Tue, 17 Nov 2015 02:07:58 GMT
On Sun, Nov 08, 2015 at 11:26:07PM -0500, James McCoy wrote:
> The attached patch makes the Ruby 2.2 test suite failure I mentioned in
> [0] go away, but this is all code I'm pretty unfamiliar with.
> 
> https://mail-archives.apache.org/mod_mbox/subversion-dev/201511.mbox/ajax/%3C20151108030937.GC8248%40freya.jamessan.com%3E
> 
> [[[
> Create a new Ruby Object instead of attempting to modify nil.
> 
> Starting in Ruby 2.2, the nil, true, and false objects are frozen.  This
> was causing test_repos.rb's test_load to fail due to calling
> "repos.load_fs(nil)".  This results in svn_swig_rb_make_stream trying to
> attributes on nil, which isn't allowed.
> 
> * subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.c:
>   (svn_swig_rb_make_stream): Create a new Object if the given io is nil.
>    Also call svn_swig_rb_get_pool in order to deduplicate some
>    pool-handling code.
> ]]]

Ping?

Cheers,
-- 
James
GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy <jamessan@debian.org>

Mime
View raw message