Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm
Precedence: bulk
Message-ID: <55C4FEB6.1060602@wandisco.com>
Date: Fri, 07 Aug 2015 20:53:42 +0200
From: =?UTF-8?B?QnJhbmtvIMSMaWJlag==?= <brane@wandisco.com>
Organization: WANdisco
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10;
 rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: dev@subversion.apache.org
Subject: Re: svn commit: r1694502 [1/6] - in /subversion/trunk: ./
 notes/subversion/include/private/
 subversion/libsvn_fs_x/ subversion/libsvn_subr/subversion/tests/cmdline/
 subversion/tests/libsvn_fs/subversion/tests/libsvn_fs_x/
References: <20150806140457.8CF36AC0335@hades.apache.org>
	<55c3faf3.0d3dc20a.7732.ffffc434@mx.google.com>
 <CA+t0gk1xspjok=z=O6hW0qeLwmfU2isPjRsFMsJpLFrq6=4PNQ@mail.gmail.com>
In-Reply-To: 
 <CA+t0gk1xspjok=z=O6hW0qeLwmfU2isPjRsFMsJpLFrq6=4PNQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

On 07.08.2015 15:02, Stefan Fuhrmann wrote:
> On Fri, Aug 7, 2015 at 1:25 AM, <bert@qqmail.nl
> <mailto:bert@qqmail.nl>> wrote:
>
>     [And now to the proper list]
>
>      
>
>     On the buildbots I see
>
>     [[[
>
>     ..\..\..\subversion\tests\libsvn_fs_x\fs-x-pack-test.c:873,
>
>     ..\..\..\subversion\libsvn_fs_x\batch_fsync.c:386,
>
>     ..\..\..\subversion\libsvn_fs_x\batch_fsync.c:343,
>
>     ..\..\..\subversion\libsvn_subr\io.c:3515: (apr_err=720005)
>
>     svn_tests: E720005: Can't open file 'E:\svn-local\tests\subversion\tests\libsvn_fs_x': Access is denied.  
>
>     FAIL:  fs-x-pack-test 13: test batch fsync
>
>     ]]]
>
>     after this commit
>
>      
>
>     It looks like the batch fsync introduced in this patch is trying
>     to open a directory as a file?
>
>     That is not going to work on Windows, and probably on more
>     platforms. Opening a directory requires other functions.
>
>     Note that this code is called inside a 'SVN_ON_POSIX' block, which
>     I would assume shouldn't be active on Windows.
>
> Yup, that's where the bug is / was. It must be "#if SVN_ON_POSIX"
> instead of "#ifdef SVN_ON_POSIX". Fixed in r1694669.

Actually, we have a bit of a tradition for using #ifdef everywhere;
Julian made a number of changes during 1.9 development to make that
consistent. Would be great if the SVN_ON_POSIX symbol followed that pattern.

-- Brane