subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Reser <...@reser.org>
Subject Re: 1.7.19 and 1.8.11 [was: svn commit: r1645547 - in /subversion/branches: 1.7.x/STATUS 1.8.x/STATUS]
Date Mon, 15 Dec 2014 03:30:04 GMT
On 12/14/14 6:11 PM, Branko ─îibej wrote:
> As you've all seen, I voted against releasing 1.7.19 and 1.8.11, because
> the DAV tests don't work with HTTPd 2.4+, which is the system default on
> the latest version of OSX. I'd be surprised if OSX is the exception; it
> seems to depend not just on the HTTPd version but also on the configured
> MPM.
> 
> I found that we've had the fix on trunk in davautocheck.sh for over a
> year, and have proposed to backport it to 1.7.x and 1.8.x; it's a clean
> merge.
> 
> I therefore propose that we scratch the 1.7.19 and 1.8.11 releases,
> approve the backport and roll 1.7.20 and 1.8.12 with the fix included.

I don't disagree we should fix this.  But it's not a regression.

There are at least four possible workarounds.
  1) Set the APACHE_MPM environment variable to something other than event.
  2) Apply patches to the auto script (the backports you proposed).
  3) Choose a different MPM at httpd build time.
  4) Don't use davautocheck.sh and setup the httpd config yourself.

The first of which is very low difficulty for anyone.  It's something you need
to do if for instance you have an event default MPM httpd and what to run
mod_dav tests against BDB since we disallow event with BDB anyway.

davautocheck.sh is a convenience feature of the test suite at this point.  I'm
sure it has numerous other failings in certain circumstances.  1.6.x wouldn't
work on OS X either as I recall, yet nobody complained about it back then.

Given that you've already located the correct fixes and nominated them, in my
opinion we should just ship this release as is and then be sure to fix them for
the next release.

So my vote is not to delay this release.





Mime
View raw message