Return-Path: X-Original-To: apmail-subversion-dev-archive@minotaur.apache.org Delivered-To: apmail-subversion-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B203710B7F for ; Fri, 24 Oct 2014 08:02:19 +0000 (UTC) Received: (qmail 51244 invoked by uid 500); 24 Oct 2014 08:02:19 -0000 Delivered-To: apmail-subversion-dev-archive@subversion.apache.org Received: (qmail 51194 invoked by uid 500); 24 Oct 2014 08:02:19 -0000 Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@subversion.apache.org Received: (qmail 51184 invoked by uid 99); 24 Oct 2014 08:02:19 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Oct 2014 08:02:19 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of ivan@visualsvn.com designates 209.85.213.47 as permitted sender) Received: from [209.85.213.47] (HELO mail-yh0-f47.google.com) (209.85.213.47) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Oct 2014 08:01:53 +0000 Received: by mail-yh0-f47.google.com with SMTP id c41so3392317yho.34 for ; Fri, 24 Oct 2014 01:00:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=visualsvn.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; bh=cx/3latrVtGSPWnmbOz34uPm59+W1gJB67WKnO8LDsc=; b=ZLe72cIzKWYkpNN6+Ndd3MPoxAzCk/ugwpZFAOUF8du4XVKQYabxKqlDXodG3dssCl IN9IRKUYPzUkyxj8djZIkd9uibcMdPlu3XvbPX3p90U/VRigqNfBpeDb+aFRKuO7YtoM AHoDspsSAsKv0CwThePHfzGfPxQWt7o9kHGVo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:content-type; bh=cx/3latrVtGSPWnmbOz34uPm59+W1gJB67WKnO8LDsc=; b=TDEl+QguD/o9TJoJ8kJrW1S9ZPH3m/bwQ6yyAXzIf/UD2zKwKnmQ8HabS0xFkdIlyC L/7wSy/giTeS67M2H5RBx1HZEjoBAVZC5BD5eGM41YsVsccBRToMGU5oViRjVwUlJyQK +8LJAlGV8m4C69XMhxJIDKZawlmn2/zMyHQFBGLkOUskw+fzxBlePIpg2QzMveAfZ9/F YaP1lds80ik4FkPk/Ur8fgtfaoVUdH/oCppJn0kaFhZTe4qVrsOAtWmD89bvk86R0o9W YN7L8RoSo3/dlDF3TRBmY/52/PA6tVG0C+pNhN/g8ctRAEUQ1JRCgWJqStP8V6Q7Cm/v SHkg== X-Gm-Message-State: ALoCoQloTSbnnHddYRHhD1mM3KsX0lpmit1sv1d6eeydBoayHcJWneL5IzKQpDms9ewJw/275qor X-Received: by 10.170.195.79 with SMTP id m76mr4214401yke.30.1414137622347; Fri, 24 Oct 2014 01:00:22 -0700 (PDT) MIME-Version: 1.0 Received: by 10.140.132.81 with HTTP; Fri, 24 Oct 2014 01:00:02 -0700 (PDT) In-Reply-To: <20141023221117.EEBFB23889D5@eris.apache.org> References: <20141023221117.EEBFB23889D5@eris.apache.org> From: Ivan Zhakov Date: Fri, 24 Oct 2014 12:00:02 +0400 Message-ID: Subject: Re: svn commit: r1633967 - /subversion/trunk/subversion/tests/libsvn_fs/fs-test.c To: Subversion Development , Stefan Fuhrman Content-Type: text/plain; charset=UTF-8 X-Virus-Checked: Checked by ClamAV on apache.org On 24 October 2014 02:11, wrote: > Author: stefan2 > Date: Thu Oct 23 22:11:17 2014 > New Revision: 1633967 > > URL: http://svn.apache.org/r1633967 > Log: > Extend the test "txn list" list test to still return the correct list > after some txn got aborted. Covers svn_fs_purge_txn as well now. > > * subversion/tests/libsvn_fs/fs-test.c > (verify_txn_list): Purge txns one-by-one and verify txn list after > each step. > > > Modified: subversion/trunk/subversion/tests/libsvn_fs/fs-test.c > URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/libsvn_fs/fs-test.c?rev=1633967&r1=1633966&r2=1633967&view=diff > ============================================================================== > --- subversion/trunk/subversion/tests/libsvn_fs/fs-test.c (original) > +++ subversion/trunk/subversion/tests/libsvn_fs/fs-test.c Thu Oct 23 22:11:17 2014 > @@ -319,6 +319,25 @@ verify_txn_list(const svn_test_opts_t *o > "Got a bogus txn list."); > all_good: > > + /* Get rid of the txns one at a time. */ > + SVN_ERR(svn_fs_purge_txn(fs, name1, pool)); > + > + /* There should be exactly one left. */ > + SVN_ERR(svn_fs_list_transactions(&txn_list, fs, pool)); > + > + /* Check the list. It should have *exactly* two entries. */ It seems comment doesn't match the code. -- Ivan Zhakov