Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (nike.apache.org: domain of stefan.fuhrmann@wandisco.com
 designates 209.85.213.174 as permitted sender)
MIME-Version: 1.0
Date: Mon, 20 Oct 2014 15:16:39 +0200
Message-ID: 
 <CA+t0gk2PC7nFQ3gc-anz=ZdRWK0fy=RY_CvXEB0v7aWeqRcY4Q@mail.gmail.com>
Subject: FS API functions missing FS API tests
From: Stefan Fuhrmann <stefan.fuhrmann@wandisco.com>
To: Subversion Development <dev@subversion.apache.org>
Content-Type: multipart/alternative; boundary=001a113fde046f41d70505da8651

--001a113fde046f41d70505da8651
Content-Type: text/plain; charset=UTF-8

Hi there,

I've been going through svn_fs.h and found that the following
functions aren't being called directly in any of our tests. They
may still be tested indirectly through higher level functions but
I think most of them should get a low-level test as well:

svn_fs_access_get_username
svn_fs_access_add_lock_token2
svn_fs_purge_txn
svn_fs_txn_base_revision
svn_fs_is_txn_root
svn_fs_is_revision_root
svn_fs_txn_root_name
svn_fs_path_change2_create
svn_fs_check_path
svn_fs_is_file
svn_fs_node_relation
svn_fs_node_created_path
svn_fs_props_different
svn_fs_props_changed
svn_fs_get_mergeinfo2
svn_fs_merge
svn_fs_dir_optimal_order
svn_fs_file_length
svn_fs_file_checksum(sha1)
svn_fs_try_process_file_contents
svn_fs_contents_different
svn_fs_contents_changed
svn_fs_info_config_files
svn_fs_get_file_delta_stream
svn_fs_lock_target_set_token
svn_fs_get_locks2
svn_fs_print_modules

[svn_fs_node_history2, svn_fs_history_prev2 are opaque and will
 be tested through 'svn log']

I'll be working through that list by the end of this week and add
tests where they are simple enough and then post an updated list
here.

-- Stefan^2.

--001a113fde046f41d70505da8651
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div><div>Hi there,<br><br></div>I&#39;ve been going throu=
gh svn_fs.h and found that the following<br></div>functions aren&#39;t bein=
g called directly in any of our tests. They<br>may still be tested indirect=
ly through higher level functions but<br>I think most of them should get a =
low-level test as well:<br><br><div>svn_fs_access_get_username<br></div><di=
v>svn_fs_access_add_lock_token2<br>svn_fs_purge_txn<br>svn_fs_txn_base_revi=
sion<br>svn_fs_is_txn_root<br>svn_fs_is_revision_root<br>svn_fs_txn_root_na=
me<br>svn_fs_path_change2_create<br>svn_fs_check_path<br>svn_fs_is_file<br>=
svn_fs_node_relation<br>svn_fs_node_created_path<br>svn_fs_props_different<=
br>svn_fs_props_changed<br>svn_fs_get_mergeinfo2<br>svn_fs_merge<br>svn_fs_=
dir_optimal_order<br>svn_fs_file_length<br>svn_fs_file_checksum(sha1)<br>sv=
n_fs_try_process_file_contents<br>svn_fs_contents_different<br>svn_fs_conte=
nts_changed<br>svn_fs_info_config_files<br>svn_fs_get_file_delta_stream<br>=
svn_fs_lock_target_set_token<br>svn_fs_get_locks2<br>svn_fs_print_modules<b=
r><br>[svn_fs_node_history2, svn_fs_history_prev2 are opaque and will<br></=
div><div>=C2=A0be tested through &#39;svn log&#39;]<br><br></div><div>I&#39=
;ll be working through that list by the end of this week and add<br>tests w=
here they are simple enough and then post an updated list<br>here.<br><br><=
/div><div>-- Stefan^2.<br></div></div>

--001a113fde046f41d70505da8651--