Return-Path: X-Original-To: apmail-subversion-dev-archive@minotaur.apache.org Delivered-To: apmail-subversion-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 21697171D4 for ; Mon, 20 Oct 2014 13:17:16 +0000 (UTC) Received: (qmail 44210 invoked by uid 500); 20 Oct 2014 13:17:15 -0000 Delivered-To: apmail-subversion-dev-archive@subversion.apache.org Received: (qmail 44160 invoked by uid 500); 20 Oct 2014 13:17:15 -0000 Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@subversion.apache.org Received: (qmail 44143 invoked by uid 99); 20 Oct 2014 13:17:15 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 Oct 2014 13:17:15 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of stefan.fuhrmann@wandisco.com designates 209.85.223.174 as permitted sender) Received: from [209.85.223.174] (HELO mail-ie0-f174.google.com) (209.85.223.174) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 Oct 2014 13:17:11 +0000 Received: by mail-ie0-f174.google.com with SMTP id tr6so4508343ieb.5 for ; Mon, 20 Oct 2014 06:16:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wandisco.com; s=gapps; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=99MJBwKwCTeM2LEf+CBd+9jW2YfwpswZlppqpuVH038=; b=OUFgWSOWcjViDaEIEY9oLsyVdunCyh+XgqlmXWILKyWMf2xrE/Ev8QpCMQWO/BYflr noJ5cbhUszCXl1EPCmEuh3+rKN3sxO7HCq3UKqNJQVaWWNQlrmSNd60+7HFX4JzKIGub tPQhRaji+7kC16qdEbjU5wiUS9cew3u5Uqc1o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=99MJBwKwCTeM2LEf+CBd+9jW2YfwpswZlppqpuVH038=; b=HfV/enhRZLhfUQqp/AFZ11rXBfVNBPUfqcODEbiP1xmQpnMxYpK0MJUJX7JKqXy7vd xxkJRGrbSPA2Pa+HFpVS8u2tSFCmJidAi7tbylM9v8LNxefiWlLgXkAuBt2nQeF71uqV Z9E/kf8itQuLkZiC7UUAUnSxjU3XW7Rrk8bszAsS7dbzY2pdejA52ePTlTcPmLnC2oHV V7PkjOLc8Tilla8zLT7CIYu2qnB8UZnp76lNRB8GfUxSvh6AH1OXUNOlkiJ+UsXzcYzr ZkRObiRsZ/CVGQ3/Mlon6kpJwko41tKWUCZuw2r/jjHaN+EM8VV+4J/BXgqAzGIm3EnU 99vQ== X-Gm-Message-State: ALoCoQl6FrW8rFJ4zQrX4iF03kPT61YZYr3BWYusXvfHugkQXP7L05bMETwFgF1dJtbFJhJwYPMH MIME-Version: 1.0 X-Received: by 10.107.135.13 with SMTP id j13mr2867062iod.56.1413811010728; Mon, 20 Oct 2014 06:16:50 -0700 (PDT) Received: by 10.50.224.138 with HTTP; Mon, 20 Oct 2014 06:16:50 -0700 (PDT) In-Reply-To: References: <20141001164146.B6418238899C@eris.apache.org> Date: Mon, 20 Oct 2014 15:16:50 +0200 Message-ID: Subject: Re: svn commit: r1628762 - /subversion/trunk/subversion/libsvn_fs_fs/low_level.c From: Stefan Fuhrmann To: Ivan Zhakov Cc: Subversion Development , Stefan Fuhrman Content-Type: multipart/alternative; boundary=001a113f8d2e130cd80505da8787 X-Virus-Checked: Checked by ClamAV on apache.org --001a113f8d2e130cd80505da8787 Content-Type: text/plain; charset=UTF-8 On Wed, Oct 1, 2014 at 7:42 PM, Ivan Zhakov wrote: > On 1 October 2014 20:41, wrote: > > Author: stefan2 > > Date: Wed Oct 1 16:41:46 2014 > > New Revision: 1628762 > > > > URL: http://svn.apache.org/r1628762 > > Log: > > * subversion/libsvn_fs_fs/low_level.c > > (read_change): Fix reporting of the "mergeinfo_mod" flag for changed > > paths if the flag insn't actually stored in the repo. > > We must explicitly initialize it to > svn_tristate_unknown. > > > Hi Stefan, > > Could you please add test for this FSFS bug? It will help in future FS > backend(s) development. > Yup, done in r1631184. As it turned out, there was no test for svn_fs_paths_changed2() at all that I could have simply augmented ... -- Stefan^2. --001a113f8d2e130cd80505da8787 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On Wed, Oct 1, 2014 at 7:42 PM, Ivan Zhakov <ivan@visualsvn.com&g= t; wrote:
On 1 = October 2014 20:41,=C2=A0 <stefan2@apache.org> wrote:
> Author: stefan2
> Date: Wed Oct=C2=A0 1 16:41:46 2014
> New Revision: 1628762
>
> URL: http= ://svn.apache.org/r1628762
> Log:
> * subversion/libsvn_fs_fs/low_level.c
>=C2=A0 =C2=A0(read_change): Fix reporting of the "mergeinfo_mod&qu= ot; flag for changed
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 paths if= the flag insn't actually stored in the repo.
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 We must = explicitly initialize it to svn_tristate_unknown.
>
Hi Stefan,

Could you please add test for this FSFS bug? It will help in future FS
backend(s) development.

Yup, done in r1= 631184.

As it turned out, there was no test for svn_fs_pa= ths_changed2()
at all that I could have simply augmented ...<= /div>
-- Stefan^2.

--001a113f8d2e130cd80505da8787--