Return-Path: X-Original-To: apmail-subversion-dev-archive@minotaur.apache.org Delivered-To: apmail-subversion-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A45B6C4D2 for ; Tue, 4 Jun 2013 04:03:43 +0000 (UTC) Received: (qmail 32586 invoked by uid 500); 4 Jun 2013 04:03:43 -0000 Delivered-To: apmail-subversion-dev-archive@subversion.apache.org Received: (qmail 32476 invoked by uid 500); 4 Jun 2013 04:03:42 -0000 Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@subversion.apache.org Received: (qmail 31696 invoked by uid 99); 4 Jun 2013 04:03:41 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Jun 2013 04:03:41 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of gstein@gmail.com designates 74.125.82.171 as permitted sender) Received: from [74.125.82.171] (HELO mail-we0-f171.google.com) (74.125.82.171) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Jun 2013 04:03:34 +0000 Received: by mail-we0-f171.google.com with SMTP id m46so2429636wev.30 for ; Mon, 03 Jun 2013 21:03:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=QjGg7TKqaNZkAdoEtq8rrWq3oBLQS4iEKo04x8RgdBc=; b=ZwjfaVobWRejWKj7/+PX+c+lAuHzPvJDJZuib5btjn4xlSOfSwqDGy1wAhJsKAtwTT L243BHitfuxSwzlHiSWZX4Rs/SguvGhmOXlchCYba2VkqY/HxvmdsfENAHX2vCJwBKjZ xMmx4ONHlm38yb83uB5q+oeQGkpF+52XhcJwv7+/FbWql5qleBZUuNoVMj3JmOosXozS klInJJQeEmRoCCwBnnQk1bTak4HEbiftdrKfPDu+yDLe4681c59CtVZQCqbQ4+loYJTz iWTGuMDcIfYvF//zd5P19JFM89h+s9OldSA/H7POLhriOhiYS0cIPsl5M5Ig6ohy1iN0 XiOQ== MIME-Version: 1.0 X-Received: by 10.180.184.112 with SMTP id et16mr783029wic.58.1370318594565; Mon, 03 Jun 2013 21:03:14 -0700 (PDT) Received: by 10.194.89.103 with HTTP; Mon, 3 Jun 2013 21:03:14 -0700 (PDT) In-Reply-To: <20130603221242.6B4DD2388906@eris.apache.org> References: <20130603221242.6B4DD2388906@eris.apache.org> Date: Tue, 4 Jun 2013 00:03:14 -0400 Message-ID: Subject: Re: svn commit: r1489203 - /subversion/trunk/subversion/libsvn_client/merge.c From: Greg Stein To: dev@subversion.apache.org Content-Type: text/plain; charset=ISO-8859-1 X-Virus-Checked: Checked by ClamAV on apache.org Would "%s@%ld and %s@%ld must have a common ancestor" be easier to translate? The term "ancestrally related" seems a bit complicated for translation :-P On Mon, Jun 3, 2013 at 6:12 PM, wrote: > Author: julianfoad > Date: Mon Jun 3 22:12:41 2013 > New Revision: 1489203 > > URL: http://svn.apache.org/r1489203 > Log: > * subversion/libsvn_client/merge.c > (find_automatic_merge): Error instead of crashing if source branch is not > related to target branch. > > Found by: steveking > > Modified: > subversion/trunk/subversion/libsvn_client/merge.c > > Modified: subversion/trunk/subversion/libsvn_client/merge.c > URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_client/merge.c?rev=1489203&r1=1489202&r2=1489203&view=diff > ============================================================================== > --- subversion/trunk/subversion/libsvn_client/merge.c (original) > +++ subversion/trunk/subversion/libsvn_client/merge.c Mon Jun 3 22:12:41 2013 > @@ -12307,6 +12307,12 @@ find_automatic_merge(svn_client__pathrev > SVN_ERR(svn_client__get_youngest_common_ancestor( > &s_t->yca, s_t->source, &s_t->target->loc, s_t->source_ra_session, > ctx, result_pool, result_pool)); > + if (! s_t->yca) > + return svn_error_createf(SVN_ERR_CLIENT_NOT_READY_TO_MERGE, NULL, > + _("'%s@%ld' must be ancestrally related to " > + "'%s@%ld'"), > + s_t->source->url, s_t->source->rev, > + s_t->target->loc.url, s_t->target->loc.rev); > > /* Find the latest revision of A synced to B and the latest > * revision of B synced to A. > >