subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neels Hofmeyr <>
Subject Re: [PATCH] Make work on Windows
Date Mon, 03 Jun 2013 11:38:03 GMT
Branko ─îibej <>:
> I believe the patch is not correct. It assumes unlimited buffering on
> the stdout and stderr pipes, which is never the case. The way Popen is
> used on the patch can cause the parent and child processes to
> deadlock.
> I suggest using Popen.communicate instead.

Agreed. communicate() is what I'd have used, too.

Any other problems with the patch?

It possibly is incompatible with some older version of
python ... but I'd argue that subprocess.Popen is old enough.


View raw message