Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: neutral (nike.apache.org: 209.85.212.170 is neither permitted
 nor denied by domain of codematters@ntlworld.com)
Sender: MARTIN PHILIP <codematters@ntlworld.com>
From: Philip Martin <philip.martin@wandisco.com>
To: Joe Swatosh <joe.swatosh@gmail.com>
Cc: Bert Huijben <bert@qqmail.nl>,  SVN Dev <dev@subversion.apache.org>
Subject: Re: [PATCH] #include limts.h for ULONG_MAX
References: <1462531598536607980@unknownmsgid> <87vc8f8zkd.fsf@ntlworld.com>
	<CALmGkLmws8A3MdED2=PEqK+7sq74n=qSP2SxJPyCRKGmc3WdEw@mail.gmail.com>
Date: Tue, 26 Mar 2013 09:46:52 +0000
In-Reply-To: 
 <CALmGkLmws8A3MdED2=PEqK+7sq74n=qSP2SxJPyCRKGmc3WdEw@mail.gmail.com>
	(Joe Swatosh's message of "Mon, 25 Mar 2013 17:24:39 -0700")
Message-ID: <87a9pqebn7.fsf@ntlworld.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.4 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

Joe Swatosh <joe.swatosh@gmail.com> writes:

> Thanks Philip and Bert, perhaps this along with Philip's changes?
>
> [[[
> Index: subversion/include/svn_types.h
> ===================================================================
> --- subversion/include/svn_types.h      (revision 1460925)
> +++ subversion/include/svn_types.h      (working copy)
> @@ -1241,7 +1241,7 @@
>   *
>   * @since New in 1.7.
>   */
> -#define SVN_LINENUM_MAX_VALUE ULONG_MAX
> +#define SVN_LINENUM_MAX_VALUE APR_UINT64_MAX
>
> ]]]

That's not right for two reasons.  svn_linenum_t is unsigned long and
that may not be 64 bits; if it's 32 bits we need a 32 bit value.  Also
this is a public header file and older APR don't define APR_UINT64_MAX.

I don't see any APR constant that gives us the maximum value for an
unsigned long so I think ULONG_MAX is the only option here.  From your
earlier patch it appears you need limits.h for that.  What I don't
understand is that svn_types.h includes apr.h and apr.h should include
include limits.h.  Does your apr not have

#define APR_HAVE_LIMITS_H        1

/* header files for PATH_MAX, _POSIX_PATH_MAX */
#if APR_HAVE_LIMITS_H
#include <limits.h>
#else
#if APR_HAVE_SYS_SYSLIMITS_H
#include <sys/syslimits.h>
#endif
#endif

-- 
Certified & Supported Apache Subversion Downloads:
http://www.wandisco.com/subversion/download