subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Swatosh <joe.swat...@gmail.com>
Subject Re: [PATCH] #include limts.h for ULONG_MAX
Date Tue, 26 Mar 2013 00:24:39 GMT
Thanks Philip and Bert, perhaps this along with Philip's changes?

[[[
Index: subversion/include/svn_types.h
===================================================================
--- subversion/include/svn_types.h      (revision 1460925)
+++ subversion/include/svn_types.h      (working copy)
@@ -1241,7 +1241,7 @@
  *
  * @since New in 1.7.
  */
-#define SVN_LINENUM_MAX_VALUE ULONG_MAX
+#define SVN_LINENUM_MAX_VALUE APR_UINT64_MAX

]]]

On Mon, Mar 25, 2013 at 4:54 AM, Philip Martin
<philip.martin@wandisco.com> wrote:
> In r1460628 I changed the code to use svn_cstring_strtoui64 and so avoid
> ULONG_MAX.
>
> Bert Huijben <bert@qqmail.nl> writes:
>
>> Isn't there an apr variant of this macro we can/should use?
>>
>> Bert From: Joe Swatosh
>> Sent: 25-3-2013 01:01
>> To: SVN Dev
>> Subject: [PATCH] #include limts.h for ULONG_MAX
>> While I found this issue using my very old compiler, it seems
>> reasonable since that is where ULONG_MAX has been defined for a long
>> time. (Since clearly no one else is running into this).
>
> --
> Certified & Supported Apache Subversion Downloads:
> http://www.wandisco.com/subversion/download

Mime
View raw message