Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (nike.apache.org: domain of blair@orcaware.com designates
 108.0.197.17 as permitted sender)
Message-ID: <5033D975.6090204@orcaware.com>
Date: Tue, 21 Aug 2012 11:54:45 -0700
From: Blair Zajac <blair@orcaware.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:14.0) Gecko/20120714 Thunderbird/14.0
MIME-Version: 1.0
To: Philip Martin <philip.martin@wandisco.com>
CC: "C. Michael Pilato" <cmpilato@collab.net>, dev@subversion.apache.org
Subject: Re: svn commit: r1375675 - in /subversion/trunk/subversion:
 include/svn_repos.h
 libsvn_repos/fs-wrap.c libsvn_repos/hooks.c libsvn_repos/repos.c
 libsvn_repos/repos.h
 tests/cmdline/commit_tests.py tests/cmdline/svntest/actions.py
References: <20120821172941.2A0E72388962@eris.apache.org>
 <5033CB53.80806@orcaware.com> <5033CEDD.3080701@collab.net>
 <5033D387.9010702@orcaware.com> <87393g84p2.fsf@stat.home.lan>
In-Reply-To: <87393g84p2.fsf@stat.home.lan>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

On 08/21/2012 11:45 AM, Philip Martin wrote:
> Blair Zajac <blair@orcaware.com> writes:
>
>> On 08/21/2012 11:09 AM, C. Michael Pilato wrote:
>>>
>>> I actually considered using "post-create-txn" and renaming "start-commit" to
>>> "pre-create-txn" (with code to run "start-commit" iff not "pre-create-txn"
>>> hook exists, for compat purposes).
>>
>> +1.  I always have to remember which comes first, start-commit or
>> pre-commit, so this renaming helps.
>
> Suppose both pre-create-txn and start-commit exist.  Is it an error?
> If not which one is run?

I don't think it's an error, run both of them.  I don't have any 
thoughts on the ordering, perhaps start-commit first, since it's always 
been there?

> We have already bumped the FSFS format in 1.8 but we have not yet bumped
> the repos format.  Perhaps we could bump and have an upgrade that
> renames the hook?

That would be make repos maintenance easier in the long run.

Blair