subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Branko ─îibej <br...@wandisco.com>
Subject Re: svn commit: r1374357 - in /subversion/trunk: Makefile.in build.conf build/ac-macros/apache.m4 build/generator/gen_base.py build/generator/gen_make.py build/generator/templates/makefile.ezt
Date Tue, 21 Aug 2012 19:25:10 GMT
On 21.08.2012 18:57, Daniel Shahaf wrote:
> A few comments on read-through (but without checking out-of-mail
> context):
[...]
> Could you document 'when' somewhere in the tree itself, please?  In
> build.conf comments, or build/generator/, I don't care, but not just in
> the log message please. :-)

Eh. Good point. Not that the rest of the generator is all that well
documented.

[...]

>> @@ -396,7 +397,8 @@ class Generator(gen_base.GeneratorBase):
>>  
>>          # ### TODO: This is a hack.  See discussion here:
>>          # ### http://mid.gmane.org/20120316191639.GA28451@daniel3.local
> Is this comment still applicable?

I have no idea.
[...]

> Suggest:
>
>   if [if-any target.when]$([target.when])[else]true[endif] ; then ...
>
> This avoids the need for another if-any at the end of the line.

Good idea.

> +	[if-any areas.files.when]if $([areas.files.when]) ; then [else][end]
> +	cd [areas.files.dirname] ; $(MKDIR) "$(APACHE_LIBEXECDIR)" ; $(INSTALL_MOD_SHARED)
-n [areas.files.name] [areas.files.filename]
> +	[if-any areas.files.when] ; fi[else][end][end]
> Should the line above be:
>
>   +	[end][if-any areas.files.when] ; fi[else][end]
>
> ?

Nope, the last [end] closes the [for areas.files].

-- Brane

-- 
Certified & Supported Apache Subversion Downloads:
http://www.wandisco.com/subversion/download


Mime
View raw message