Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (nike.apache.org: domain of danklima@gmail.com designates
 209.85.216.43 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:date:message-id:subject:from:to:content-type;
        b=Vd11u5S/oBJ8xl0eYCfUqv2oWOw/Xy5M4YpGcoN594fxcAFW8E4i3xOMhRld2SM+EO
         Vf92BFrwHbyG7IXVhB1Lj5EmY0w4/Ow9OmkPTBum+vFNLpRfv+GKXuTe5789kdVpWnb0
         +laAR+8UwP8neiq8jwbxAlRY0TucCAOgFEwe8=
MIME-Version: 1.0
Date: Thu, 6 Jan 2011 13:34:28 +0100
Message-ID: <AANLkTinniEQzXY8qe37TKwgphS2rqH=-8SBsSCo70zf3@mail.gmail.com>
Subject: svn_client_update4 depth: exclude and externals
From: =?ISO-8859-1?Q?Daniel_Kl=EDma?= <danklima@gmail.com>
To: dev@subversion.apache.org
Content-Type: text/plain; charset=ISO-8859-1

Hello.

Currently svn 1.7-trunk doesn't support excluding externals from wc,
altough it used to.(Sometime between multi-db and single-db it stopped working)

It seems that in (libsvn_wc/crop.c) in function svn_wc_exclude at
line:220 checks
only if it is root (contains admin area) and errors out if so and it doesn't
see/check bigger picture (prop external).

Further there is deeper in exclude proccess (libsvn_wc/adm_ops.c)
in svn_wc__internal_remove_from_revision_control at line 1928
call to svn_wc__adm_destroy even though there is no admin directory
since single-db.

Either one could fix exclude of externals (ommiting while checkout/"update to"
lasts until next update,then externals are added again) or remove
call to svn_wc__adm_destroy.(if excluding externals was/is unwanted)

As for fixing, one would have to inform in some way svn_wc_exclude
about case (external/wc root).

Last thing:current 1.7-trunk also leaves behind directories containing externals
after exclude.

Thanks.

Daniel Klima

P.S.:I tried to fit manualy in 72-chars width while using gmail,so I might
have misscounted or misscorrect.
(at least I never saw option for char/column width in gmail)