Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (nike.apache.org: domain of noorul@collab.net designates
 204.16.106.198 as permitted sender)
From: Noorul Islam K M <noorul@collab.net>
To: "Hyrum K. Wright" <hyrum_wright@mail.utexas.edu>
Cc: dev@subversion.apache.org
Subject: Re: [PATCH] Fix syntax inconsistency and update comments.
References: <87wrn2e2zy.fsf@noorul.maa.corp.collab.net>
	<AANLkTi=nHtAguyaheXJhx_-i1hZL3WcOyBru0A9aM-vL@mail.gmail.com>
	<87y67hoqs9.fsf@noorul.maa.corp.collab.net>
	<8739pmbjqf.fsf@sajida.noorul.com>
Date: Tue, 04 Jan 2011 14:23:23 +0530
In-Reply-To: <8739pmbjqf.fsf@sajida.noorul.com> (Noorul Islam K. M.'s message
	of "Sat, 25 Dec 2010 09:13:20 +0530")
Message-ID: <877helyrr0.fsf@noorul.maa.corp.collab.net>
User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/24.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Noorul Islam K M <noorul@collab.net> writes:

> Noorul Islam K M <noorul@collab.net> writes:
>
>> "Hyrum K. Wright" <hyrum_wright@mail.utexas.edu> writes:
>>
>>> On Wed, Dec 22, 2010 at 12:27 AM, Noorul Islam K M <noorul@collab.net> =
wrote:
>>>
>>>>
>>>> Find attached minor patch which makes 'if' syntax consistent and also
>>>> some comment improvements.
>>>>
>>>> Log
>>>>
>>>> [[[
>>>>
>>>> Fix syntax inconsistency and update comments.
>>>>
>>>> * libsvn_client/locking_commands.c
>>>> =C2=A0(organize_lock_targets): Fix syntax inconsistency. Update commen=
ts.
>>>
>>> *What* about the syntax inconsistency are you fixing?  White space?
>>> Function names? Use of braces?  (I can tell by looking at the patch,
>>> but a more informative log message would be nice.)
>>>
>>> Same with "update comments".  Update them in what way?
>>>
>>
>> Please find updated log message.
>>
>> [[[
>>
>> Fix syntax inconsistency and update comments.
>>
>> * libsvn_client/locking_commands.c
>>   (organize_lock_targets): Fix syntax inconsistency by removing
>>     unnecessary braces from 'if' block. Update comments to reflect new
>>     function names used.
>>
>> Patch by: Noorul Islam K M <noorul{_AT_}collab.net>
>> ]]]
>>
>
> I was thinking that this one is a trivial fix.
>

Just reminding so that someone take a look at this patch. I know this is
not so important but still wonder why such a trivial patch takes time to
get reviewed and committed.

Thanks and Regards
Noorul