Return-Path: Delivered-To: apmail-subversion-dev-archive@minotaur.apache.org Received: (qmail 43032 invoked from network); 5 Jan 2011 13:14:54 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 5 Jan 2011 13:14:54 -0000 Received: (qmail 75520 invoked by uid 500); 5 Jan 2011 13:14:54 -0000 Delivered-To: apmail-subversion-dev-archive@subversion.apache.org Received: (qmail 75405 invoked by uid 500); 5 Jan 2011 13:14:54 -0000 Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@subversion.apache.org Received: (qmail 75397 invoked by uid 99); 5 Jan 2011 13:14:53 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Jan 2011 13:14:53 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=RCVD_IN_DNSWL_NONE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: local policy) Received: from [66.111.4.25] (HELO out1.smtp.messagingengine.com) (66.111.4.25) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Jan 2011 13:14:45 +0000 Received: from compute1.internal (compute1.nyi.mail.srv.osa [10.202.2.41]) by gateway1.messagingengine.com (Postfix) with ESMTP id E0C5820943; Wed, 5 Jan 2011 08:14:24 -0500 (EST) Received: from frontend1.messagingengine.com ([10.202.2.160]) by compute1.internal (MEProxy); Wed, 05 Jan 2011 08:14:24 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=messagingengine.com; h=date:from:to:cc:subject:message-id:references:mime-version:content-type:in-reply-to; s=smtpout; bh=GFhy8bfd9fktr6jKhrO1dfsA/Iw=; b=LwmLLPYJNBtc/uZaHEEO89gkQkqvH88qjJV+3IosYyfKRtsqtrydJVoukeoCGrTxtpjOPgf0QffQOX+UQEkbRLlnwbGZckH04uHoep+9GZy44V1DTUW1EknlN6h1RPdoMAiMidKLQ8KLeM0j3loIsTr+VoMuXUUpSPMWD2BMbEQ= X-Sasl-enc: XjE7MghzzRzdKtrgxTaUYXv8w9bgdJqAo9V8PKhqvx33tUPwFiB88+ypTDPa5Q 1294233264 Received: from daniel3.local (bzq-79-176-18-95.red.bezeqint.net [79.176.18.95]) by mail.messagingengine.com (Postfix) with ESMTPSA id 0841C40A1D7; Wed, 5 Jan 2011 08:14:23 -0500 (EST) Date: Wed, 5 Jan 2011 15:11:35 +0200 From: Daniel Shahaf To: Prabhu Gnana Sundar Cc: dev@subversion.apache.org Subject: Re: [PATCH] '--version --quiet' should display only the version info in svnadmin, svnlook, svnsync, svndumpfilter, svnversion, svnserve Message-ID: <20110105131135.GB12319@daniel3.local> References: <1294227766.25028.10.camel@prabhugnanasundar> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1294227766.25028.10.camel@prabhugnanasundar> User-Agent: Mutt/1.5.18 (2008-05-17) X-Virus-Checked: Checked by ClamAV on apache.org Prabhu Gnana Sundar wrote on Wed, Jan 05, 2011 at 17:12:46 +0530: > Hi all, > > Currently svnadmin, svnlook, svnsync, svndumpfilter, svnversion, > svnserve show the entire version information even if '--version --quiet' > is given as command. > > The '--quiet' option has *not* been handled so far. > > This patch would make svnadmin, svnlook, svnsync, svndumpfilter, > svnversion, svnserve '--version --quiet' to display *only* the version > number(info) just like 'svn --version --quiet' does. > Heh. This is one of the things I looked into, back before I was formally involved with the project... (as patch manager and later a committer) But I never sent in a patch for this, because I reckoned that a patch that just adds a --quiet option everywhere (and uses it just for --version --quiet) would serve more as a 'practice for Daniel in sending patches' and less as 'a patch that Subversion needs'. So I looked for more 'real' patches (eg, copy_tests 48) to work on. Not to say that this patch is unnecessary (maybe you have a usecase wherein it's required), but if you're looking to cut your teeth, I can suggest a few more challening things to work on. :-) > I have attached the patch and the log message with this mail. Please > give your views on this. > > > Thanks and regards > Prabhu