subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Prabhu Gnana Sundar <prabh...@collab.net>
Subject Re: [PATCH] make diff against copy-source by default
Date Fri, 07 Jan 2011 10:15:16 GMT
Hi Julian,

On Thu, 2011-01-06 at 16:25 +0530, Prabhu Gnana Sundar wrote:

> > Isn't it a layering violation for libsvn_wc to know about libsvn_ra?
> > Maybe this needs to use callbacks or something, so that all the RA
> > knowledge remains in libsvn_client.
> > 
> 
> What you say is correct. :)
> But since we need to access a file which is not in our text-base. I had
> to get the ra_session to make use of the repository to fetch the file.
> 
> Anyway now I am working on this to make use of any function in
> libsvn_client that would get me an ra_session. But that seems to me like
> a costly work.
> 

I was trying to make use of some functions from libsvn_client to keep
the RA knowldege in the libsvn_client. In that course, I ended up in a
"circular dependency" in the 'build.conf'.

I had to include the "svn_client.h" in the 'subversion/libsvn_wc/diff.c'
file. So I updated the build.conf file and ran the 'autogen.sh' script,
there by ending up in *error*.

Here is the snip:

<snip>

Traceback (most recent call last):
  File "./gen-make.py", line 313, in <module>
    main(conf, gentype, skip_depends=skip, other_options=rest.list)
  File "./gen-make.py", line 65, in main
    generator.write()
  File "build/generator/gen_make.py", line 375, in write
    files = gen_base._sorted_files(self.graph, area)
  File "build/generator/gen_base.py", line 1148, in _sorted_files
    raise CircularDependencies()
gen_base.CircularDependencies

</snip>

I could not find any other way than teaching libsvn_ra to libsvn_wc
inorder to fetch a file from the repo (like done in the patch). Am very
glad if you have other suggestions :)


Thanks and regards
Prabhu


Mime
View raw message