Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id EC390200BF1 for ; Tue, 3 Jan 2017 09:57:04 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id EAFE8160B43; Tue, 3 Jan 2017 08:57:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 62797160B33 for ; Tue, 3 Jan 2017 09:57:04 +0100 (CET) Received: (qmail 81794 invoked by uid 500); 3 Jan 2017 08:56:58 -0000 Mailing-List: contact issues-help@struts.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@struts.apache.org Delivered-To: mailing list issues@struts.apache.org Received: (qmail 81784 invoked by uid 99); 3 Jan 2017 08:56:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Jan 2017 08:56:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 723FA2C1F54 for ; Tue, 3 Jan 2017 08:56:58 +0000 (UTC) Date: Tue, 3 Jan 2017 08:56:58 +0000 (UTC) From: "Lukasz Lenart (JIRA)" To: issues@struts.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (WW-4730) TokenInterceptor synchronized on session.getId().intern() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 03 Jan 2017 08:57:05 -0000 [ https://issues.apache.org/jira/browse/WW-4730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15794553#comment-15794553 ] Lukasz Lenart commented on WW-4730: ----------------------------------- [~simone.cordaro] did you observe any side-effects? > TokenInterceptor synchronized on session.getId().intern() > --------------------------------------------------------- > > Key: WW-4730 > URL: https://issues.apache.org/jira/browse/WW-4730 > Project: Struts 2 > Issue Type: Bug > Components: Core Interceptors > Affects Versions: 2.5.x > Reporter: Simone Cordaro > Labels: interceptors, patch, token > Fix For: 2.5.next > > Attachments: TokenInterceptor.java > > > As already done on TokenSessionStoreInterceptor, TokenInterceptor's handleToken method need to be synchronized on "session.getId().intern()" instead of "session" -- This message was sent by Atlassian JIRA (v6.3.4#6332)