Mailing-List: contact issues-help@struts.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@struts.apache.org
Date: Tue, 10 Jan 2017 18:06:58 +0000 (UTC)
From: "ASF subversion and git services (JIRA)" <jira@apache.org>
To: issues@struts.apache.org
Message-ID: <JIRA.13024792.1480603439000.699062.1484071618724@Atlassian.JIRA>
In-Reply-To: <JIRA.13024792.1480603439000@Atlassian.JIRA>
References: <JIRA.13024792.1480603439000@Atlassian.JIRA> <JIRA.13024792.1480603439251@arcas>
Subject: [jira] [Commented] (WW-4722) Portlet Issue with I18Interceptor
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 10 Jan 2017 18:07:00 -0000


    [ https://issues.apache.org/jira/browse/WW-4722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15815691#comment-15815691 ] 

ASF subversion and git services commented on WW-4722:
-----------------------------------------------------

Commit d12bb7cddbc8f3ebbba64d3df209bb078735e8ea in struts's branch refs/heads/master from [~lukaszlenart]
[ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=d12bb7c ]

WW-4722 Uses proper read method


> Portlet Issue with I18Interceptor
> ---------------------------------
>
>                 Key: WW-4722
>                 URL: https://issues.apache.org/jira/browse/WW-4722
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core Interceptors, Plugin - Portlet
>    Affects Versions: 2.5.5
>            Reporter: Todd Kofford
>            Assignee: Lukasz Lenart
>              Labels: interceptors, portlet
>             Fix For: 2.5.8
>
>
> Portlets always throw the following exception:
> {quote}
> java.lang.IllegalStateException: Not allowed in a portlet
> {quote}
> Below is the method in the classs
> *org.apache.struts2.portlet.servlet.PortletServletRequest* where this always
> happens:
> {code:java}
> public Cookie[] getCookies() {
>     if (portletRequest instanceof HttpServletRequest) {
>         return ((HttpServletRequest) portletRequest).getCookies();
>     }
>     throw new IllegalStateException("Not allowed in a portlet");
> }
> {code}
> Apparently, the "portletRequest" variable is not an instance of "HttpServletRequest".
> *NOTE -* There are many other methods in class *PortletServletRequest* that use the exact same assumption/logic as the "getCookies()" method.
> That class is invoked by the class
> *org.apache.struts2.interceptor.I18nInterceptor*, which was just changed in version 2.5.5. See change [https://issues.apache.org/jira/browse/WW-4686]
> Finally, below is a partial stack trace
> {quote}
> SEVERE: Servlet.service() for servlet struts2portlet threw exception
> java.lang.IllegalStateException: Not allowed in a portlet
> 	at
> org.apache.struts2.portlet.servlet.PortletServletRequest.getCookies(PortletServletRequest.java:101)
> 	at
> org.apache.struts2.interceptor.I18nInterceptor.readStoredLocale(I18nInterceptor.java:215)
> 	at
> org.apache.struts2.interceptor.I18nInterceptor.storeLocale(I18nInterceptor.java:189)
> 	at
> org.apache.struts2.interceptor.I18nInterceptor.intercept(I18nInterceptor.java:144)
> 	at
> com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:240)
> 	at
> org.apache.struts2.interceptor.ServletConfigInterceptor.intercept(ServletConfigInterceptor.java:171)
> 	at
> com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:240)
> 	at
> com.opensymphony.xwork2.interceptor.AliasInterceptor.intercept(AliasInterceptor.java:195)
> 	at
> com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:240)
> 	at
> com.opensymphony.xwork2.interceptor.ExceptionMappingInterceptor.intercept(ExceptionMappingInterceptor.java:193)
> 	at
> com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:240)
> 	at
> org.apache.struts2.portlet.interceptor.PortletAwareInterceptor.intercept(PortletAwareInterceptor.java:81)
> 	at
> com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:240)
> 	at
> org.apache.struts2.portlet.interceptor.PortletStateInterceptor.intercept(PortletStateInterceptor.java:51)
> 	at
> com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:240)
> 	at
> org.apache.struts2.factory.StrutsActionProxy.execute(StrutsActionProxy.java:54)
> 	at
> org.apache.struts2.portlet.dispatcher.Jsr168Dispatcher.serviceAction(Jsr168Dispatcher.java:481)
> 	at
> org.apache.struts2.portlet.dispatcher.Jsr168Dispatcher.render(Jsr168Dispatcher.java:341)
> 	at
> org.jasig.portal.portlet.container.FilterChainImpl.doFilter(FilterChainImpl.java:183)
> 	at
> org.jasig.portal.portlet.container.FilterChainImpl.processFilter(FilterChainImpl.java:99)
> 	at
> org.jasig.portal.portlet.container.FilterManagerImpl.processFilter(FilterManagerImpl.java:110)
> 	at
> org.apache.pluto.container.driver.PortletServlet.dispatch(PortletServlet.java:340)
> 	at
> org.apache.pluto.container.driver.PortletServlet.doGet(PortletServlet.java:261)
> 	at javax.servlet.http.HttpServlet.service(HttpServlet.java:622)
> 	at javax.servlet.http.HttpServlet.service(HttpServlet.java:729)
> {quote}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)