struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <>
Subject [jira] [Commented] (WW-4174) Make OgnlValueStack and OgnlValueStackFactory More Extensible
Date Mon, 02 Jan 2017 07:20:58 GMT


ASF subversion and git services commented on WW-4174:

Commit 55fed537646ba33d6789deb15f0d8ef99b870594 in struts's branch refs/heads/master from
[;h=55fed53 ]

WW-4174 Makes fields protected to allow easily override

> Make OgnlValueStack and OgnlValueStackFactory More Extensible
> -------------------------------------------------------------
>                 Key: WW-4174
>                 URL:
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Value Stack
>    Affects Versions:
>            Reporter: Kevin Conroy
>            Assignee: Lukasz Lenart
>             Fix For:
> I'm not trying to reopen XW-613 and have taken the advice from the mailing list seriously
about not just requesting changes to the default behavior or log levels.
> Instead, I'd like to propose changing some private methods in OgnlValueStack to be protected
so that developers can more easily extend OgnlValueStack to implement their desired logging/warning/exception
behavior for their application.
> I'd like to propose that the following methods in OgnlValueStack (currently private in
scope) should be changed to protected:
> {code}
> protected void handleRuntimeException(String expr, Object value, boolean throwExceptionOnFailure,
RuntimeException re)
> protected void handleOgnlException(String expr, Object value, boolean throwExceptionOnFailure,
OgnlException e)
> protected void setupExceptionOnFailure(boolean throwExceptionOnFailure)
> protected Object handleOtherException(String expr, boolean throwExceptionOnFailure, Exception
> protected Object handleOgnlException(String expr, boolean throwExceptionOnFailure, OgnlException
> protected boolean shouldLogNoSuchPropertyWarning(OgnlException e)
> protected Object findInContext(String name)
> {code}
> Additionally, to enable the OgnlValueStackFactory to be easily extended to return any
overridden OgnlValueStack implementations, the currently private data members should be given
protected getters:
> {code}
>    protected XWorkConverter getXworkConverter()
>    {
>       return xworkConverter;
>    }
>    protected CompoundRootAccessor getCompoundRootAccessor()
>    {
>       return compoundRootAccessor;
>    }
>    protected TextProvider getTextProvider()
>    {
>       return textProvider;
>    }
>    protected Container getContainer()
>    {
>       return container;
>    }
>    protected boolean isAllowStaticMethodAccess()
>    {
>       return allowStaticMethodAccess;
>    }
> {code}
> This would allow developers like myself to more easily extend and override behavior to
better fit our own desired notification levels. For example, these changes would allow me
to set it up to provide info level warnings in the log file while suppressing the exception
that gets thrown.
> Protected level scope ensures that my custom extensions can more easily inherit bug fixes
and behavior changes from future versions.
> Thanks!

This message was sent by Atlassian JIRA

View raw message