Return-Path: 
 <issues-return-24327-apmail-struts-issues-archive=struts.apache.org@struts.apache.org>
X-Original-To: apmail-struts-issues-archive@minotaur.apache.org
Delivered-To: apmail-struts-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 4976C11116
	for <apmail-struts-issues-archive@minotaur.apache.org>;
 Fri,  1 Aug 2014 08:24:39 +0000 (UTC)
Received: (qmail 94526 invoked by uid 500); 1 Aug 2014 08:24:38 -0000
Delivered-To: apmail-struts-issues-archive@struts.apache.org
Received: (qmail 94489 invoked by uid 500); 1 Aug 2014 08:24:38 -0000
Mailing-List: contact issues-help@struts.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@struts.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@struts.apache.org>
List-Post: <mailto:issues@struts.apache.org>
List-Id: <issues.struts.apache.org>
Reply-To: dev@struts.apache.org
Delivered-To: mailing list issues@struts.apache.org
Received: (qmail 94478 invoked by uid 99); 1 Aug 2014 08:24:38 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Aug 2014 08:24:38 +0000
Date: Fri, 1 Aug 2014 08:24:38 +0000 (UTC)
From: "Lukasz Lenart (JIRA)" <jira@apache.org>
To: issues@struts.apache.org
Message-ID: <JIRA.12635480.1362538958116.93575.1406881478667@arcas>
In-Reply-To: <JIRA.12635480.1362538958116@arcas>
References: <JIRA.12635480.1362538958116@arcas>
Subject: [jira] [Commented] (WW-3992) TypeConversion fails in Struts 2.3.8
 in devMode due to configuration xml reload instead of annotation config
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/WW-3992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14082065#comment-14082065 ] 

Lukasz Lenart commented on WW-3992:
-----------------------------------

The mentioned code fragment that supposed to produce NPE:
{code:java}
URL fileUrl = ClassLoaderUtil.getResource(buildConverterFilename(clazz), clazz);
if (fileManager.fileNeedsReloading(fileUrl)) {
     mapping = buildConverterMapping(clazz);
}
{code}

and {{FileManager#fileNeedsReloading}} detects {{null}}s so it won't throw NPE

> TypeConversion fails in Struts 2.3.8 in devMode due to configuration xml reload instead of annotation config
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: WW-3992
>                 URL: https://issues.apache.org/jira/browse/WW-3992
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core Actions, Other
>    Affects Versions: 2.3.8
>         Environment: java 1.6u24, tomcat 6.0.32
>            Reporter: Hugo Robayo
>            Priority: Minor
>              Labels: TypeConversion
>             Fix For: 2.3.18
>
>
> With struts.devMode is set to true, each request the BeanSelectionProvider class evaluates this code:
> {code:java}
> if ("true".equalsIgnoreCase(props.getProperty(StrutsConstants.STRUTS_DEVMODE))) {
> ...
> props.setProperty(StrutsConstants.STRUTS_CONFIGURATION_XML_RELOAD, "true");
> ...
> {code}
> It causes  {{@TypeConversion}} will not recognize by XWorkConverter class in method {{conditionalReload()}} it tries to reload xml configuration instead of annotation configurations then this:
> {code:java}
> ...
> URL fileUrl = ClassLoaderUtil.getResource(buildConverterFilename(clazz), clazz);
> ...
> {code}
> returns null then it causes {{NullPointerException}} in the next line, so no conversion is applied.
> Trying to solve this, but with no success
> {code:xml}
>     <constant name="reloadXmlConfiguration" value="false"/>
>     <constant name="struts.configuration.xml.reload" value="false"/>
> {code}
> then, temporary solution to no set to false struts.devMode until someone helps me, recompile BeanSelectionProvider with:
> {code:java}
> ...
> props.setProperty(StrutsConstants.STRUTS_CONFIGURATION_XML_RELOAD, "false"); 
> ...
> {code}
> when  devMode is true.



--
This message was sent by Atlassian JIRA
(v6.2#6252)