Return-Path: 
 <commits-return-14937-apmail-struts-commits-archive=struts.apache.org@struts.apache.org>
X-Original-To: apmail-struts-commits-archive@minotaur.apache.org
Delivered-To: apmail-struts-commits-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id BE5631825F
	for <apmail-struts-commits-archive@minotaur.apache.org>;
 Tue, 13 Oct 2015 11:28:23 +0000 (UTC)
Received: (qmail 54118 invoked by uid 500); 13 Oct 2015 11:28:23 -0000
Delivered-To: apmail-struts-commits-archive@struts.apache.org
Received: (qmail 54083 invoked by uid 500); 13 Oct 2015 11:28:23 -0000
Mailing-List: contact commits-help@struts.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@struts.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@struts.apache.org>
List-Post: <mailto:commits@struts.apache.org>
List-Id: <commits.struts.apache.org>
Reply-To: dev@struts.apache.org
Delivered-To: mailing list commits@struts.apache.org
Received: (qmail 54074 invoked by uid 99); 13 Oct 2015 11:28:23 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Oct 2015 11:28:23 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id 14A27DFC8E; Tue, 13 Oct 2015 11:28:23 +0000 (UTC)
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: cnenning@apache.org
To: commits@struts.apache.org
Date: Tue, 13 Oct 2015 11:28:24 -0000
Message-Id: <c9804551abf540148b5218aa96a8030e@git.apache.org>
In-Reply-To: <0cba4e271da54e44b0b2ab6f9f0b0f32@git.apache.org>
References: <0cba4e271da54e44b0b2ab6f9f0b0f32@git.apache.org>
X-Mailer: ASF-Git Admin Mailer
Subject: [2/3] struts git commit: made spring-core an optional compile
 dependency, as that is required for javadoc of jdk8

made spring-core an optional compile dependency, as that is required for javadoc of jdk8


Project: http://git-wip-us.apache.org/repos/asf/struts/repo
Commit: http://git-wip-us.apache.org/repos/asf/struts/commit/e0f258f7
Tree: http://git-wip-us.apache.org/repos/asf/struts/tree/e0f258f7
Diff: http://git-wip-us.apache.org/repos/asf/struts/diff/e0f258f7

Branch: refs/heads/master
Commit: e0f258f718c4bae691b6b73cb196a3bf55492114
Parents: 9d5b948
Author: cnenning <cnenning@apache.org>
Authored: Tue Oct 13 13:06:35 2015 +0200
Committer: cnenning <cnenning@apache.org>
Committed: Tue Oct 13 13:06:35 2015 +0200

----------------------------------------------------------------------
 plugins/portlet/pom.xml | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/struts/blob/e0f258f7/plugins/portlet/pom.xml
----------------------------------------------------------------------
diff --git a/plugins/portlet/pom.xml b/plugins/portlet/pom.xml
index da5a8ca..b7500f7 100644
--- a/plugins/portlet/pom.xml
+++ b/plugins/portlet/pom.xml
@@ -11,6 +11,8 @@
     <name>Struts 2 Portlet Plugin</name>
 
     <dependencies>
+        <!-- junit and related JARs are needed for 'compile'! -->
+        <!-- Due to StrutsPortletTestCase shall be distributed to applications. -->
         <dependency>
             <groupId>org.apache.struts</groupId>
             <artifactId>struts2-junit-plugin</artifactId>
@@ -23,6 +25,14 @@
             <optional>true</optional>
         </dependency>
 
+        <!-- spring-core is required for javadoc of jdk8 -->
+        <!-- It is indirectly referenced by struts2-junit-plugin. -->
+        <dependency>
+            <groupId>org.springframework</groupId>
+            <artifactId>spring-core</artifactId>
+            <optional>true</optional>
+        </dependency>
+
         <dependency>
             <groupId>javax.servlet</groupId>
             <artifactId>jsp-api</artifactId>
@@ -101,11 +111,6 @@
             <optional>true</optional>
         </dependency>
         <dependency>
-            <groupId>org.springframework</groupId>
-            <artifactId>spring-core</artifactId>
-            <scope>test</scope>
-        </dependency>
-        <dependency>
             <groupId>commons-fileupload</groupId>
             <artifactId>commons-fileupload</artifactId>
             <scope>test</scope>