Return-Path: Delivered-To: apmail-struts-commits-archive@locus.apache.org Received: (qmail 56665 invoked from network); 27 Jul 2008 06:26:21 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 27 Jul 2008 06:26:21 -0000 Received: (qmail 33629 invoked by uid 500); 27 Jul 2008 06:26:20 -0000 Delivered-To: apmail-struts-commits-archive@struts.apache.org Received: (qmail 33595 invoked by uid 500); 27 Jul 2008 06:26:20 -0000 Mailing-List: contact commits-help@struts.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@struts.apache.org Delivered-To: mailing list commits@struts.apache.org Received: (qmail 33586 invoked by uid 99); 27 Jul 2008 06:26:20 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 26 Jul 2008 23:26:20 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 27 Jul 2008 06:25:34 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 17AD0238889C; Sat, 26 Jul 2008 23:26:00 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r680067 - in /struts/struts2/branches/STRUTS_2_0_X/core/src: main/java/org/apache/struts2/views/jsp/iterator/SubsetIteratorTag.java test/java/org/apache/struts2/views/jsp/SubsetIteratorTagTest.java Date: Sun, 27 Jul 2008 06:25:59 -0000 To: commits@struts.apache.org From: wsmoak@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20080727062600.17AD0238889C@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: wsmoak Date: Sat Jul 26 23:25:58 2008 New Revision: 680067 URL: http://svn.apache.org/viewvc?rev=680067&view=rev Log: [WW-2734] Fix impossible casts, reported by FindBugs. Modified: struts/struts2/branches/STRUTS_2_0_X/core/src/main/java/org/apache/struts2/views/jsp/iterator/SubsetIteratorTag.java struts/struts2/branches/STRUTS_2_0_X/core/src/test/java/org/apache/struts2/views/jsp/SubsetIteratorTagTest.java Modified: struts/struts2/branches/STRUTS_2_0_X/core/src/main/java/org/apache/struts2/views/jsp/iterator/SubsetIteratorTag.java URL: http://svn.apache.org/viewvc/struts/struts2/branches/STRUTS_2_0_X/core/src/main/java/org/apache/struts2/views/jsp/iterator/SubsetIteratorTag.java?rev=680067&r1=680066&r2=680067&view=diff ============================================================================== --- struts/struts2/branches/STRUTS_2_0_X/core/src/main/java/org/apache/struts2/views/jsp/iterator/SubsetIteratorTag.java (original) +++ struts/struts2/branches/STRUTS_2_0_X/core/src/main/java/org/apache/struts2/views/jsp/iterator/SubsetIteratorTag.java Sat Jul 26 23:25:58 2008 @@ -214,7 +214,7 @@ count = ((Long)countObj).intValue(); } else if (countObj instanceof Double) { - count = ((Long)countObj).intValue(); + count = ((Double)countObj).intValue(); } else if (countObj instanceof String) { try { @@ -240,7 +240,7 @@ start = ((Long)startObj).intValue(); } else if (startObj instanceof Double) { - start = ((Long)startObj).intValue(); + start = ((Double)startObj).intValue(); } else if (startObj instanceof String) { try { Modified: struts/struts2/branches/STRUTS_2_0_X/core/src/test/java/org/apache/struts2/views/jsp/SubsetIteratorTagTest.java URL: http://svn.apache.org/viewvc/struts/struts2/branches/STRUTS_2_0_X/core/src/test/java/org/apache/struts2/views/jsp/SubsetIteratorTagTest.java?rev=680067&r1=680066&r2=680067&view=diff ============================================================================== --- struts/struts2/branches/STRUTS_2_0_X/core/src/test/java/org/apache/struts2/views/jsp/SubsetIteratorTagTest.java (original) +++ struts/struts2/branches/STRUTS_2_0_X/core/src/test/java/org/apache/struts2/views/jsp/SubsetIteratorTagTest.java Sat Jul 26 23:25:58 2008 @@ -243,6 +243,21 @@ } + public void testWithDoubleCount() throws Exception { + SubsetIteratorTag tag = new SubsetIteratorTag(); + tag.setPageContext(pageContext); + tag.setCount("3.0"); + tag.doStartTag(); + tag.doEndTag(); + } + + public void testWithDoubleStart() throws Exception { + SubsetIteratorTag tag = new SubsetIteratorTag(); + tag.setPageContext(pageContext); + tag.setStart("2.0"); + tag.doStartTag(); + tag.doEndTag(); + } public Action getAction() { return new ActionSupport() {