streams-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (STREAMS-557) RiakHttpClient would be more useful if it exposed baseUrl publically
Date Sat, 23 Dec 2017 06:51:00 GMT

    [ https://issues.apache.org/jira/browse/STREAMS-557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16302240#comment-16302240
] 

ASF GitHub Bot commented on STREAMS-557:
----------------------------------------

steveblackmon closed pull request #409: STREAMS-557
URL: https://github.com/apache/streams/pull/409
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/streams-contrib/streams-persist-riak/src/main/java/org/apache/streams/riak/http/RiakHttpClient.java
b/streams-contrib/streams-persist-riak/src/main/java/org/apache/streams/riak/http/RiakHttpClient.java
index 7155b52b4..c5a64814b 100644
--- a/streams-contrib/streams-persist-riak/src/main/java/org/apache/streams/riak/http/RiakHttpClient.java
+++ b/streams-contrib/streams-persist-riak/src/main/java/org/apache/streams/riak/http/RiakHttpClient.java
@@ -102,4 +102,7 @@ public HttpClient client() {
     return client;
   }
 
+  public URI getBaseURI() {
+    return baseURI;
+  }
 }


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> RiakHttpClient would be more useful if it exposed baseUrl publically
> --------------------------------------------------------------------
>
>                 Key: STREAMS-557
>                 URL: https://issues.apache.org/jira/browse/STREAMS-557
>             Project: Streams
>          Issue Type: Improvement
>            Reporter: Steve Blackmon
>
> CloseableHttpClient doesn't handle appending path fragments to base paths, so RiakHttpClient
would be more useful if it exposed baseUrl publicly so the library using it could do so 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message