streams-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (STREAMS-508) Utilize new third-party rest proxy capability in provider-twitter
Date Wed, 21 Jun 2017 02:39:00 GMT

    [ https://issues.apache.org/jira/browse/STREAMS-508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16056879#comment-16056879
] 

ASF GitHub Bot commented on STREAMS-508:
----------------------------------------

Github user steveblackmon commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/368#discussion_r123142296
  
    --- Diff: streams-contrib/streams-provider-twitter/src/main/jsonschema/org/apache/streams/twitter/api/FavoritesListRequest.json
---
    @@ -0,0 +1,41 @@
    +{
    +  "$schema": "http://json-schema.org/draft-03/schema",
    +  "$license": [
    +    "http://www.apache.org/licenses/LICENSE-2.0"
    +  ],
    +  "id": "#",
    +  "javaType" : "org.apache.streams.twitter.api.FavoritesListRequest",
    +  "javaInterfaces": ["java.io.Serializable"],
    +  "properties": {
    +    "user_id": {
    +      "description": "The ID of the user for whom to return results. Either an id or
screen_name is required for this method.",
    +      "required": false,
    +      "type": "integer"
    --- End diff --
    
    i don't think so.
    a) the bean contains a long and 
    b) the rest api turns it into a string param before sending it.
    it may be the case that whomever is coding to this interface would be better off passing
in Long.parseLong(id_str) than id - but i think if the argument is always a number the sdk
should model it as such.



> Utilize new third-party rest proxy capability in provider-twitter
> -----------------------------------------------------------------
>
>                 Key: STREAMS-508
>                 URL: https://issues.apache.org/jira/browse/STREAMS-508
>             Project: Streams
>          Issue Type: Improvement
>            Reporter: Steve Blackmon
>            Assignee: Steve Blackmon
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> Requires upgrade juneau dependency to 6.2.1 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message