streams-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (STREAMS-458) GPlusTypeConverter fails processing recent plus#person without a gender
Date Sat, 26 Nov 2016 06:41:58 GMT

    [ https://issues.apache.org/jira/browse/STREAMS-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15697405#comment-15697405
] 

ASF GitHub Bot commented on STREAMS-458:
----------------------------------------

Github user smarthi commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/331#discussion_r89666770
  
    --- Diff: streams-contrib/streams-provider-google/google-gplus/src/test/java/org/apache/streams/gplus/test/processors/GooglePlusTypeConverterIT.java
---
    @@ -121,16 +122,10 @@ public void testProcessActivity() throws IOException, ActivitySerializerExceptio
             GooglePlusActivityUtil.updateActivity(gPlusActivity, activity);
     
             assertEquals(retList.size(), 1);
    -        assert (retList.get(0).getDocument() instanceof Activity);
    +        assert(retList.get(0).getDocument() instanceof Activity);
    --- End diff --
    
    change to Assert.assertTrue(retList.get(0) instanceOf Activity);


> GPlusTypeConverter fails processing recent plus#person without a gender
> -----------------------------------------------------------------------
>
>                 Key: STREAMS-458
>                 URL: https://issues.apache.org/jira/browse/STREAMS-458
>             Project: Streams
>          Issue Type: Bug
>            Reporter: Steve Blackmon
>            Assignee: Steve Blackmon
>             Fix For: 0.5
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> Running GPlusTypeConverterTest against the output of GPlusUserDataProviderIT:
> java.lang.NullPointerException: null
> 	at com.google.gplus.serializer.util.GPlusPersonDeserializer.deserialize(GPlusPersonDeserializer.java:65)
> Rework to ensure GPlusTypeConverter doesn't crash on valid input.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message