Return-Path: X-Original-To: apmail-storm-user-archive@minotaur.apache.org Delivered-To: apmail-storm-user-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DFA06175B5 for ; Mon, 2 Feb 2015 19:27:46 +0000 (UTC) Received: (qmail 85892 invoked by uid 500); 2 Feb 2015 19:27:47 -0000 Delivered-To: apmail-storm-user-archive@storm.apache.org Received: (qmail 85850 invoked by uid 500); 2 Feb 2015 19:27:46 -0000 Mailing-List: contact user-help@storm.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: user@storm.apache.org Delivered-To: mailing list user@storm.apache.org Received: (qmail 85840 invoked by uid 99); 2 Feb 2015 19:27:46 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Feb 2015 19:27:46 +0000 X-ASF-Spam-Status: No, hits=1.8 required=5.0 tests=FREEMAIL_ENVFROM_END_DIGIT,HTML_MESSAGE,MIME_QP_LONG_LINE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of boneill42@gmail.com designates 209.85.216.52 as permitted sender) Received: from [209.85.216.52] (HELO mail-qa0-f52.google.com) (209.85.216.52) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Feb 2015 19:27:42 +0000 Received: by mail-qa0-f52.google.com with SMTP id x12so30576233qac.11 for ; Mon, 02 Feb 2015 11:25:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:user-agent:date:subject:from:to:message-id:thread-topic :references:in-reply-to:mime-version:content-type; bh=/p2XgaVu4QrIGKyRtGR7Xz9OGIVaez55RdePdXXK/rs=; b=nEyiT1Xh82gQqBdxglcSJbLdqDOAW6r+H8EuRJiJHql2COVA6hdqZwF01GpVCkI/Vw zEqm/h/6NBt4BCXvFtZL85doSuKBYyYw8GASQbnIWhPeoNlz/vTdhfQgiqBFOdvUhdCw M1oocs5yxqE2u1g1ALHhTqIf8n2lxG5uE3wmXC12/fMgMusek8h1/Uf0zsC6tbQrOnA5 dqGheLy84lB4XIGvD7X5b/oTetYJj9Gn3TRt1rGjOdREGuRH+5X4JtNNoUMw+exSNYPZ Ns91dUxYh6ItFSURpA9U13Hpj3MVLQyNvQF6Bg7HeioDCmVLIM7lMLZqx2JHJmSq444Q TjoQ== X-Received: by 10.224.114.209 with SMTP id f17mr45330736qaq.68.1422905106992; Mon, 02 Feb 2015 11:25:06 -0800 (PST) Received: from [10.60.71.81] ([67.132.206.254]) by mx.google.com with ESMTPSA id 103sm17650043qgg.11.2015.02.02.11.25.04 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 02 Feb 2015 11:25:06 -0800 (PST) Sender: "Brian O'Neill" User-Agent: Microsoft-MacOutlook/14.4.7.141117 Date: Mon, 02 Feb 2015 14:25:01 -0500 Subject: Re: AOP in Storm From: Brian O'Neill To: Message-ID: Thread-Topic: AOP in Storm References: In-Reply-To: Mime-version: 1.0 Content-type: multipart/alternative; boundary="B_3505731907_7658067" X-Virus-Checked: Checked by ClamAV on apache.org > This message is in MIME format. Since your mail reader does not understand this format, some or all of this message may not be legible. --B_3505731907_7658067 Content-type: text/plain; charset="ISO-8859-1" Content-transfer-encoding: quoted-printable Found this as well: http://docs.codehaus.org/display/AW/AOP+Benchmark --- Brian O'Neill=20 Chief Technology Officer Health Market Science, a LexisNexis Company 215.588.6024 Mobile =80 @boneill42 This information transmitted in this email message is for the intended recipient only and may contain confidential and/or privileged material. If you received this email in error and are not the intended recipient, or the person responsible to deliver it to the intended recipient, please contact the sender at the email above and delete this email and any attachments and destroy any copies thereof. Any review, retransmission, dissemination, copying or other use of, or taking any action in reliance upon, this information by persons or entities other than the intended recipient is strictly prohibited. =20 From: Kobi Salant Reply-To: Date: Monday, February 2, 2015 at 3:08 AM To: Subject: Re: AOP in Storm Thank Brian again, Do you think there are any performance issues regarding the Aspect framewor= k itself? I am not talking about the code itself that of course will have an overhead. Thanks Kobi On Sun, Feb 1, 2015 at 2:42 PM, Brian O'Neill wrote= : > We use aspectj and create point cuts: >=20 > /** > * Common Reactor Pointcuts > * http://blog.espenberntsen.net/2010/03/20/aspectj-cheat-sheet/ > */ > @Pointcut("execution(* execute(..))") > public void execute() {} >=20 > @Pointcut("execution(* updateState(..))") > public void updateState() {} >=20 > @Pointcut("execution(* *..EntityJdbiState.commit(..))") > public void commit() {} >=20 > Things get woven into the jar via aspectj-maven-plugin. >=20 > For state object, the updateState and commit point cuts above would get > triggered. >=20 > We then use the point cut to log execution times, e.g.: >=20 > protected Object logExecution(ProceedingJoinPoint pjp) throws Throwable = { >=20 >=20 > -brian >=20 > --- > Brian O'Neill=20 > Chief Technology Officer > Health Market Science, a LexisNexis Company > 215.588.6024 Mobile =80 @boneill42 > >=20 >=20 > This information transmitted in this email message is for the intended > recipient only and may contain confidential and/or privileged material. I= f you > received this email in error and are not the intended recipient, or the p= erson > responsible to deliver it to the intended recipient, please contact the s= ender > at the email above and delete this email and any attachments and destroy = any > copies thereof. Any review, retransmission, dissemination, copying or oth= er > use of, or taking any action in reliance upon, this information by person= s or > entities other than the intended recipient is strictly prohibited. > =20 >=20 >=20 > From: Kobi Salant > Reply-To: > Date: Sunday, February 1, 2015 at 7:29 AM > To: > Subject: Re: AOP in Storm >=20 > Thanks Brian, >=20 > If it is not too much to ask, can you give me a brief description how you > instrument it and access the satets. >=20 > Kobi >=20 > On Sun, Feb 1, 2015 at 2:22 PM, Brian O'Neill wro= te: >> Yes, we use AOP to get metrics/timings for individual functions/states w= ithin >> Storm. >> It works like a charm. >>=20 >> If you=B9d like, we could potentially open source that code. >>=20 >> -brian >>=20 >> --- >> Brian O'Neill=20 >> Chief Technology Officer >> Health Market Science, a LexisNexis Company >> 215.588.6024 Mobile =80 @boneill42 >> >>=20 >>=20 >> This information transmitted in this email message is for the intended >> recipient only and may contain confidential and/or privileged material. = If >> you received this email in error and are not the intended recipient, or = the >> person responsible to deliver it to the intended recipient, please conta= ct >> the sender at the email above and delete this email and any attachments = and >> destroy any copies thereof. Any review, retransmission, dissemination, >> copying or other use of, or taking any action in reliance upon, this >> information by persons or entities other than the intended recipient is >> strictly prohibited. >> =20 >>=20 >>=20 >> From: Kobi Salant >> Reply-To: >> Date: Sunday, February 1, 2015 at 2:28 AM >> To: >> Subject: AOP in Storm >>=20 >> Hi, >>=20 >> Did anyone add any experience in adding "Aspect" to Storm? >> Is there any reason not to do it? >>=20 >> Thanks >> Kobi >>=20 >> This message may contain confidential and/or privileged information. >> If you are not the addressee or authorized to receive this on behalf of = the >> addressee you must not use, copy, disclose or take action based on this >> message or any information herein. >> If you have received this message in error, please advise the sender >> immediately by reply email and delete this message. Thank you. >=20 >=20 > This message may contain confidential and/or privileged information. > If you are not the addressee or authorized to receive this on behalf of t= he > addressee you must not use, copy, disclose or take action based on this > message or any information herein. > If you have received this message in error, please advise the sender > immediately by reply email and delete this message. Thank you. This message may contain confidential and/or privileged information. If you are not the addressee or authorized to receive this on behalf of the addressee you must not use, copy, disclose or take action based on this message or any information herein. If you have received this message in error, please advise the sender immediately by reply email and delete this message. Thank you. --B_3505731907_7658067 Content-type: text/html; charset="ISO-8859-1" Content-transfer-encoding: quoted-printable
Found this as well:=

--= -

Brian O'Neill 

Chief Technology Officer

Health Market Science, a LexisNexis Company

215.588.6024 Mobile • @boneill42&nb= sp;

=

This information t= ransmitted in this email message is for the intended recipient only and may = contain confidential and/or privileged material. If you received this email = in error and are not the intended recipient, or the person responsible to de= liver it to the intended recipient, please contact the sender at the email a= bove and delete this email and any attachments and destroy any copies thereo= f. Any review, retransmission, dissemination, copying or other use of, or ta= king any action in reliance upon, this information by persons or entities ot= her than the intended recipient is strictly prohibited.

&nbs= p;


From: Kobi Salant <kobis@liveperson.com>
Reply-To: <user@st= orm.apache.org>
Date: Monda= y, February 2, 2015 at 3:08 AM
To: = <user@storm.apache.org>Subject: Re: AOP in Storm
<= div>
Thank Brian again,

Do you th= ink there are any performance issues regarding the Aspect framework itself? = I am not talking about the code itself that of course will have an overhead.=

Thanks
Kobi

On Sun, Feb 1, 2015 at 2:42 PM, Brian O= 'Neill <bone@alumni.brown.edu> wrote:
We use aspectj and create point cuts:

    /**
     * = Common Reactor Pointcuts
  =    */
    @Pointcut("execution(* execute(..))"= )
    public void execute() {}

=     @Pointcut("execution(* updateState(..))")
  &nb= sp; public void updateState() {}

    @Poi= ntcut("execution(* *..EntityJdbiState.commit(..))")
    = public void commit() {}

Things get woven into= the jar via aspectj-maven-plugin.

For state object= , the updateState and commit point cuts above would get triggered.

We then use the point cut to log execution times, e.g.:

 protected Object logExecution(ProceedingJoinPoint= pjp) throws Throwable {


<= div>-brian

---

Brian O'Neill <= /b>

Chief Technology Officer

Health Market Science, a LexisNexis Company

215.588.6024 Mobile&nbs= p;• = @boneill42 


=

This information transmitted in this email message is for = the intended recipient only and may contain confidential and/or privileged m= aterial. If you received this email in error and are not the intended recipi= ent, or the person responsible to deliver it to the intended recipient, plea= se contact the sender at the email above and delete this email and any attac= hments and destroy any copies thereof. Any review, retransmission, dissemina= tion, copying or other use of, or taking any action in reliance upon, this i= nformation by persons or entities other than the intended recipient is stric= tly prohibited.=

 


From: Kobi Salant <kobis@liveperson.com>
Reply-To: <user@storm.apache.org>
Date: Sunday, February 1, 2015 at 7:29 AMTo: <user@storm.apache.org>
Subject: Re: AOP in Storm

Thanks Brian,

If it is = not too much to ask, can you give me a brief description how you instrument = it and access the satets.

Kobi

On Sun, Feb 1, 2015 at 2:22 PM,= Brian O'Neill <bone@alumni.brown.edu> wrote:
Yes, we use AOP to get metrics/tim= ings for individual functions/states within Storm.
It works like a= charm.

If you’d like, we could potentially o= pen source that code.  

-brian

<= /div>

---

<= b>Brian O'Neill 

Chief Technology Offi= cer

Health Market Science, a LexisNexis Company

215.588.6024 Mobile • @bon= eill42 


This inf= ormation transmitted in this email message is for the intended recipient onl= y and may contain confidential and/or privileged material. If you received t= his email in error and are not the intended recipient, or the person respons= ible to deliver it to the intended recipient, please contact the sender at t= he email above and delete this email and any attachments and destroy any cop= ies thereof. Any review, retransmission, dissemination, copying or other use= of, or taking any action in reliance upon, this information by persons or e= ntities other than the intended recipient is strictly prohibited.

 


From: = Kobi Salant <kobis@= liveperson.com>
Reply-To: &= lt;user@storm.apache.= org>
Date: Sunday, February= 1, 2015 at 2:28 AM
To: <user@storm.apache.org&g= t;
Subject: AOP in Storm
=

Hi,

Did anyone ad= d any experience in adding "Aspect" to Storm?
Is there any reason = not to do it?

Thanks
Kobi

=
This message may contain confidential and/or= privileged information. 
If you are no= t the addressee or authorized to receive this on behalf of the addressee you= must not use, copy, disclose or take action based on this message or any in= formation herein. 
If you have received= this message in error, please advise the sender immediately by reply email = and delete this message. Thank you.


This message may contain confidential = and/or privileged information. 
If you = are not the addressee or authorized to receive this on behalf of the address= ee you must not use, copy, disclose or take action based on this message or = any information herein. 
If you have re= ceived this message in error, please advise the sender immediately by reply = email and delete this message. Thank you.


This message may con= tain confidential and/or privileged information. 
If you are not the addressee or authorized to receive this on beh= alf of the addressee you must not use, copy, disclose or take action based o= n this message or any information herein. 
If you have received this message in error, please advise the sender imm= ediately by reply email and delete this message. Thank you.
--B_3505731907_7658067--