From dev-return-62077-archive-asf-public=cust-asf.ponee.io@storm.apache.org Tue Jul 21 00:24:00 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 4DFCB180647 for ; Tue, 21 Jul 2020 02:24:00 +0200 (CEST) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id DF284124BF5 for ; Tue, 21 Jul 2020 00:23:56 +0000 (UTC) Received: (qmail 63128 invoked by uid 500); 21 Jul 2020 00:23:56 -0000 Mailing-List: contact dev-help@storm.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@storm.apache.org Delivered-To: mailing list dev@storm.apache.org Received: (qmail 63112 invoked by uid 99); 21 Jul 2020 00:23:54 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Jul 2020 00:23:54 +0000 From: =?utf-8?q?GitBox?= To: dev@storm.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bstorm=5D_Crim_opened_a_new_pull_request_=233312=3A?= =?utf-8?q?_=5BSTORM-3652=5D_Last_error_not_displayed_in_Topology_summary_st?= =?utf-8?q?orm_ui?= Message-ID: Date: Tue, 21 Jul 2020 00:23:54 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Crim opened a new pull request #3312: URL: https://github.com/apache/storm/pull/3312 ## What is the purpose of the change Under storm ui "Topology summary" lastError is not getting populated, you need to go into "Component summary" ## How was the change tested ### Automated Coverage Added automated test coverage for `UIHelper` under `storm-webapp`. I only added targetted test coverage for the portion I modified as adding test complete coverage to `UIHelper.getTopologySummary()` would be a pretty large project in itself. For the changes to `Nimbus.java` I was unsure how to add automated test coverage and was unable to find any prior test coverage for it to use as an example. Open to suggestions here. ### Manual Testing I built a distribution from the source and deployed a test topology that had a bolt configured to periodically report errors. I then verified the web UI directly. **Bolt Code** ```java @Override public void execute(Tuple tuple) { if (random.nextInt(10) == 0) { collector.reportError(new RuntimeException("This is a random exception")); } } ``` **Topology Page:** image ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org