From dev-return-62070-archive-asf-public=cust-asf.ponee.io@storm.apache.org Thu Jul 16 06:17:33 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 29CDF180652 for ; Thu, 16 Jul 2020 08:17:33 +0200 (CEST) Received: (qmail 49139 invoked by uid 500); 16 Jul 2020 06:17:32 -0000 Mailing-List: contact dev-help@storm.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@storm.apache.org Delivered-To: mailing list dev@storm.apache.org Received: (qmail 49127 invoked by uid 99); 16 Jul 2020 06:17:31 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Jul 2020 06:17:31 +0000 From: =?utf-8?q?GitBox?= To: dev@storm.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bstorm=5D_bipinprasad_opened_a_new_pull_request_=23?= =?utf-8?q?3309=3A_=5BSTORM-3675=5D_Check_worker_process_death_using_/proc/?= =?utf-8?q?=3Cpid=3E_directory?= Message-ID: Date: Thu, 16 Jul 2020 06:17:31 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit bipinprasad opened a new pull request #3309: URL: https://github.com/apache/storm/pull/3309 ## What is the purpose of the change *This function can replace a system "ps" command with existence/ownership check on /proc/ directory. In additional, on loaded nodes, ps command can take a few seconds. java.io.File.exists() is expected to be much faster. Note that File watcher does not work on /proc file system and the event based approach was coded/tested and then discarded.* ## How was the change tested *new test methods in ServerUtilsTest. Also run storm, kill worker and observe log to ensure proper detection* ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org