From dev-return-62027-archive-asf-public=cust-asf.ponee.io@storm.apache.org Mon Jul 6 18:26:57 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2231018062C for ; Mon, 6 Jul 2020 20:26:57 +0200 (CEST) Received: (qmail 70851 invoked by uid 500); 6 Jul 2020 18:26:56 -0000 Mailing-List: contact dev-help@storm.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@storm.apache.org Delivered-To: mailing list dev@storm.apache.org Received: (qmail 70835 invoked by uid 99); 6 Jul 2020 18:26:56 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Jul 2020 18:26:56 +0000 From: =?utf-8?q?GitBox?= To: dev@storm.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bstorm=5D_bipinprasad_opened_a_new_pull_request_=23?= =?utf-8?q?3302=3A_=5BSTORM-3666=5D_Validate_component_name_in_rebalance_com?= =?utf-8?q?mand?= Message-ID: Date: Mon, 06 Jul 2020 18:26:56 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit bipinprasad opened a new pull request #3302: URL: https://github.com/apache/storm/pull/3302 ## What is the purpose of the change Rebalance command completes successfully when --executor option has invalid component name. This gives the impression that command was successful. Change this behavior to throw an exception. In addition, fix the help text for --executor options to show correct format. ## How was the change tested Run storm and rebalance using various correct and incorrect formats like: bin/storm rebalance --help # to show corrected help text bin/storm rebalance --executor spout:3 -w 1 word-count ## fail because of spout:3 bin/storm rebalance --executor spout=3 -w 1 word-count ## verify correct rebalance in Storm UI with spout=3 bin/storm rebalance -e spout=4 -w 1 word-count ## verify correct rebalance in Storm UI with spout=4 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org