From dev-return-62085-archive-asf-public=cust-asf.ponee.io@storm.apache.org Fri Jul 24 02:34:56 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 195A2180642 for ; Fri, 24 Jul 2020 04:34:56 +0200 (CEST) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 1A7A2125B02 for ; Fri, 24 Jul 2020 02:34:53 +0000 (UTC) Received: (qmail 58295 invoked by uid 500); 24 Jul 2020 02:34:51 -0000 Mailing-List: contact dev-help@storm.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@storm.apache.org Delivered-To: mailing list dev@storm.apache.org Received: (qmail 58282 invoked by uid 99); 24 Jul 2020 02:34:51 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Jul 2020 02:34:51 +0000 From: =?utf-8?q?GitBox?= To: dev@storm.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bstorm=5D_Crim_commented_on_a_change_in_pull_reques?= =?utf-8?q?t_=233312=3A_=5BSTORM-3652=5D_Last_error_not_displayed_in_Topolog?= =?utf-8?q?y_summary_storm_ui?= Message-ID: <159555809161.29655.11023647342527574820.asfpy@gitbox.apache.org> Date: Fri, 24 Jul 2020 02:34:51 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: Crim commented on a change in pull request #3312: URL: https://github.com/apache/storm/pull/3312#discussion_r459825843 ########## File path: storm-webapp/src/main/java/org/apache/storm/daemon/ui/UIHelpers.java ########## @@ -1488,16 +1487,21 @@ private static Double nullToZero(Double value) { * @return getTopologySpoutAggStatsMap */ private static Map getTopologySpoutAggStatsMap(ComponentAggregateStats componentAggregateStats, - String spoutId) { + String spoutId, Map config, String topologyId) { Map result = new HashMap(); CommonAggregateStats commonStats = componentAggregateStats.get_common_stats(); result.putAll(getCommonAggStatsMap(commonStats)); result.put("spoutId", spoutId); result.put("encodedSpoutId", Utils.urlEncodeUtf8(spoutId)); SpoutAggregateStats spoutAggregateStats = componentAggregateStats.get_specific_stats().get_spout(); - result.put("completeLatency", spoutAggregateStats.get_complete_latency_ms()); Review comment: Added to make consistent with how other floats are returned. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org