From dev-return-62078-archive-asf-public=cust-asf.ponee.io@storm.apache.org Tue Jul 21 00:28:00 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 48F0D180647 for ; Tue, 21 Jul 2020 02:28:00 +0200 (CEST) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 366D8124E30 for ; Tue, 21 Jul 2020 00:27:56 +0000 (UTC) Received: (qmail 81849 invoked by uid 500); 21 Jul 2020 00:27:54 -0000 Mailing-List: contact dev-help@storm.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@storm.apache.org Delivered-To: mailing list dev@storm.apache.org Received: (qmail 81425 invoked by uid 99); 21 Jul 2020 00:27:52 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Jul 2020 00:27:52 +0000 From: =?utf-8?q?GitBox?= To: dev@storm.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bstorm=5D_Crim_commented_on_a_change_in_pull_reques?= =?utf-8?q?t_=233312=3A_=5BSTORM-3652=5D_Last_error_not_displayed_in_Topolog?= =?utf-8?q?y_summary_storm_ui?= Message-ID: <159529127275.29655.18277443536406273206.asfpy@gitbox.apache.org> Date: Tue, 21 Jul 2020 00:27:52 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: Crim commented on a change in pull request #3312: URL: https://github.com/apache/storm/pull/3312#discussion_r457765344 ########## File path: storm-webapp/src/main/java/org/apache/storm/daemon/ui/UIHelpers.java ########## @@ -1519,8 +1518,12 @@ private static Double nullToZero(Double value) { result.put("executeLatency", StatsUtil.floatStr(boltAggregateStats.get_execute_latency_ms())); result.put("executed", boltAggregateStats.get_executed()); result.put("processLatency", StatsUtil.floatStr(boltAggregateStats.get_process_latency_ms())); + ErrorInfo lastError = componentAggregateStats.get_last_error(); result.put("lastError", Objects.isNull(lastError) ? "" : getTruncatedErrorString(lastError.get_error())); + if (!Objects.isNull(lastError)) { Review comment: The existing [getComponentErrorInfo()](https://github.com/Crim/storm/blob/sp/STORM-3652/storm-webapp/src/main/java/org/apache/storm/daemon/ui/UIHelpers.java#L1430-L1443) method adds the remaining properties that the UI is expecting to properly render the error. See [topology-page-template.html](https://github.com/Crim/storm/blob/sp/STORM-3652/storm-webapp/src/main/java/org/apache/storm/daemon/ui/WEB-INF/templates/topology-page-template.html#L565-L574) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org