From dev-return-62058-archive-asf-public=cust-asf.ponee.io@storm.apache.org Thu Jul 9 20:18:00 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id A6B66180607 for ; Thu, 9 Jul 2020 22:17:59 +0200 (CEST) Received: (qmail 76142 invoked by uid 500); 9 Jul 2020 20:17:58 -0000 Mailing-List: contact dev-help@storm.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@storm.apache.org Delivered-To: mailing list dev@storm.apache.org Received: (qmail 76130 invoked by uid 99); 9 Jul 2020 20:17:58 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Jul 2020 20:17:58 +0000 From: =?utf-8?q?GitBox?= To: dev@storm.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bstorm=5D_srdo_commented_on_pull_request_=233305=3A?= =?utf-8?q?_=5BSTORM-3553=5D_Upgrade_jQuery_from_1=2E11=2E1_to_3=2E5=2E1?= Message-ID: <159432587863.29655.14955776965595293863.asfpy@gitbox.apache.org> Date: Thu, 09 Jul 2020 20:17:58 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: srdo commented on pull request #3305: URL: https://github.com/apache/storm/pull/3305#issuecomment-656330732 For fixing the RAT plugin, I'd guess you should update the exclusion list in https://github.com/apache/storm/blob/master/pom.xml#L463 to include the new webapp jquery file. The license update stuff described at https://github.com/apache/storm/blob/master/DEVELOPER.md#auditing-licenses-for-licensenotice only works for dependencies tracked by Maven. As this dependency is not being pulled in via Maven, I think there is very little to do. The LICENSE and LICENSE-binary files should be updated (this is already done). JQuery doesn't have a NOTICE file so that's not a concern. I think the current changes are good. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org