From dev-return-62022-archive-asf-public=cust-asf.ponee.io@storm.apache.org Mon Jul 6 14:01:16 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 4680D180652 for ; Mon, 6 Jul 2020 16:01:16 +0200 (CEST) Received: (qmail 53220 invoked by uid 500); 6 Jul 2020 14:01:15 -0000 Mailing-List: contact dev-help@storm.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@storm.apache.org Delivered-To: mailing list dev@storm.apache.org Received: (qmail 53161 invoked by uid 99); 6 Jul 2020 14:01:15 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Jul 2020 14:01:15 +0000 From: =?utf-8?q?GitBox?= To: dev@storm.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bstorm=5D_agresch_commented_on_a_change_in_pull_req?= =?utf-8?q?uest_=233295=3A_STORM-3660=3A_Remove_use_of_queues_for_updating_c?= =?utf-8?q?redentials?= Message-ID: <159404407503.29655.7938582524683042227.asfpy@gitbox.apache.org> Date: Mon, 06 Jul 2020 14:01:15 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: agresch commented on a change in pull request #3295: URL: https://github.com/apache/storm/pull/3295#discussion_r450241225 ########## File path: storm-client/src/jvm/org/apache/storm/executor/Executor.java ########## @@ -291,6 +294,22 @@ public void accept(Object event) { } } + public void setNeedToRefreshCreds() { + this.needToRefreshCreds = true; + } + + protected void updateExecCredsIfRequired() { + if (this.needToRefreshCreds) { + this.needToRefreshCreds = false; + LOG.info("The credentials are being updated {}.", executorId); Review comment: I think info should be fine. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org