storm-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [storm] Crim opened a new pull request #3312: [STORM-3652] Last error not displayed in Topology summary storm ui
Date Tue, 21 Jul 2020 00:23:54 GMT

Crim opened a new pull request #3312:
URL: https://github.com/apache/storm/pull/3312


   ## What is the purpose of the change
   
   Under storm ui "Topology summary" lastError is not getting populated, you need to go into
"Component summary"
   
   ## How was the change tested
   
   ### Automated Coverage
   Added automated test coverage for `UIHelper` under `storm-webapp`.  I only added targetted
test coverage for the portion I modified as adding test complete coverage to `UIHelper.getTopologySummary()`
would be a pretty large project in itself.
   
   For the changes to `Nimbus.java` I was unsure how to add automated test coverage and was
unable to find any prior test coverage for it to use as an example.  Open to suggestions here.
   
   ### Manual Testing
   I built a distribution from the source and deployed a test topology that had a bolt configured
to periodically report errors.  I then verified the web UI directly.
   
   **Bolt Code**
   ```java
      @Override
       public void execute(Tuple tuple) {
               if (random.nextInt(10) == 0) {
                   collector.reportError(new RuntimeException("This is a random exception"));
               }
       }
   ```
   
   **Topology Page:**
   <img width="1748" alt="image" src="https://user-images.githubusercontent.com/571653/87998655-7e3e3c80-cb33-11ea-8e72-b9485d9ed711.png">
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message