storm-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [storm] agresch opened a new pull request #3307: STORM-3673 convert Builtin metrics to use V2 API
Date Tue, 14 Jul 2020 20:04:11 GMT

agresch opened a new pull request #3307:
URL: https://github.com/apache/storm/pull/3307


   ## What is the purpose of the change
   
   Executor builtin metrics used deprecated metrics API.  This converts them to use the current
API.
   
   ## How was the change tested
   
   Ran unit tests and ran a topology on a cluster and validated metrics seem sane.
   
   
   V2 metric replacement:
   
   CountStatAndMetric is replaced with WindowedMeter for counts.
   LatencyStatAndMetric is replaced with WindowedHistogram for latencies.
   
   The windowing code in these seems like it could be cleaned up and commonized, but I based
it on the existing code for now.  I also simplified the synchronization.
   
   TaskMetrics seem to have been a half-hearted attempt at adding v2 metrics.  They are superceded
by the other metrics added in this change.
   
   
   There can be duplicate short metric names created for a given task id due to having multiple
component/stream combinations.  As an example, a v1 metric for a task could be:
   
   __ack-count = {$mastercoord-bg0:$batch=100, $mastercoord-bg0:$success=140}]
   
   For v2, I didn't see a way to easily support multiple metrics like this and allow a non-duplicate
metric short metric name.  To work around this, I appended the component and stream to the
metric name. The v2 metric names for that v1 example are:
   
   __ack-count-$mastercoord-bg0:$batch and __ack-count-$mastercoord-bg0:$success 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message