storm-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [storm] Crim opened a new pull request #3305: [STORM-3553] Upgrade jQuery from 1.11.1 to 3.5.1
Date Wed, 08 Jul 2020 09:44:14 GMT

Crim opened a new pull request #3305:
URL: https://github.com/apache/storm/pull/3305


   ## What is the purpose of the change
   
   Upgrades jQuery from 1.11.1 to 3.5.1 for several security fixes:
   - https://www.tenable.com/plugins/nessus/124719
   - https://blog.jquery.com/2019/04/10/jquery-3-4-0-released/
   - https://snyk.io/vuln/npm:jquery
   - https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2019-11358
   
   
   ## How was the change tested
   
   There does not appear to be automated UI tests, so I manually validated the changes by
building a distribution .tar.gz file, deploying the nimbus, supervisor, UI, and logviewer
daemons locally.  I then verified each page in the UI.  See attached screen shots below.
   
   Each page was verified by checking each function, verifying it behaved as expected, and
no Javascript errors occurred.  One such error was identified and resolved in this PR.
   
   The only page I was unable to verify was the Storm Flux Yaml Viewer as I have no topology
using it to verify against.  Perhaps there is one in the example directory someone can point
me at and I can verify using it?
   
   ## Other Notes
   
   - This PR should be perfectly OK to target the 2.2.x and/or earlier branches if we want.
   - I updated the LICENSE files manually, I was unsure if these are manually curated, or
generated as part of some automated process.
   
   ## Testing Screenshots
   
   ![image](https://user-images.githubusercontent.com/571653/86903735-bb292d00-c14a-11ea-8705-97864393e0b4.png)
   
   ![image](https://user-images.githubusercontent.com/571653/86903762-c0867780-c14a-11ea-9a65-d6f33729a74d.png)
   
   ![image](https://user-images.githubusercontent.com/571653/86903777-c4b29500-c14a-11ea-9a9a-e3c1dda3c776.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message