storm-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [storm] bipinprasad opened a new pull request #3302: [STORM-3666] Validate component name in rebalance command
Date Mon, 06 Jul 2020 18:26:56 GMT

bipinprasad opened a new pull request #3302:
URL: https://github.com/apache/storm/pull/3302


   ## What is the purpose of the change
   
   Rebalance command completes successfully when --executor option has invalid component name.
This gives
   the impression that command was successful. Change this behavior to throw an exception.
In addition, fix the help
   text for --executor options to show correct format.
   
   ## How was the change tested
   
   Run storm and rebalance using various correct and incorrect formats like:
     bin/storm rebalance --help   # to show corrected help text
     bin/storm rebalance --executor spout:3 -w 1 word-count ## fail because of spout:3
     bin/storm rebalance --executor spout=3 -w 1 word-count ## verify correct rebalance in
Storm UI with spout=3
     bin/storm rebalance -e spout=4 -w 1 word-count  ## verify correct rebalance in Storm
UI with spout=4
     


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message