storm-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [storm] Crim commented on a change in pull request #3312: [STORM-3652] Last error not displayed in Topology summary storm ui
Date Tue, 21 Jul 2020 00:27:52 GMT

Crim commented on a change in pull request #3312:
URL: https://github.com/apache/storm/pull/3312#discussion_r457765344



##########
File path: storm-webapp/src/main/java/org/apache/storm/daemon/ui/UIHelpers.java
##########
@@ -1519,8 +1518,12 @@ private static Double nullToZero(Double value) {
         result.put("executeLatency", StatsUtil.floatStr(boltAggregateStats.get_execute_latency_ms()));
         result.put("executed", boltAggregateStats.get_executed());
         result.put("processLatency", StatsUtil.floatStr(boltAggregateStats.get_process_latency_ms()));
+
         ErrorInfo lastError = componentAggregateStats.get_last_error();
         result.put("lastError", Objects.isNull(lastError) ?  "" : getTruncatedErrorString(lastError.get_error()));
+        if (!Objects.isNull(lastError)) {

Review comment:
       The existing [getComponentErrorInfo()](https://github.com/Crim/storm/blob/sp/STORM-3652/storm-webapp/src/main/java/org/apache/storm/daemon/ui/UIHelpers.java#L1430-L1443)
method adds the remaining properties that the UI is expecting to properly render the error.
 See [topology-page-template.html](https://github.com/Crim/storm/blob/sp/STORM-3652/storm-webapp/src/main/java/org/apache/storm/daemon/ui/WEB-INF/templates/topology-page-template.html#L565-L574)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message